On 23/03/21 18:45 +0100, Moritz Sichert via Libstdc++ wrote:
Thank you!
You are right. The idea was that the test also tests the const overloads of
begin() and end() of reverse_view. But the view concept requires movable.
Maybe, this should just be
static_assert(std::ranges::range);
instead?
Thank you!
You are right. The idea was that the test also tests the const overloads of
begin() and end() of reverse_view. But the view concept requires movable.
Maybe, this should just be
static_assert(std::ranges::range);
instead?
The test in the patch now has the same static_assert twice.
On 23/03/21 16:25 +, Jonathan Wakely wrote:
On 03/03/21 20:26 +0100, Moritz Sichert via Libstdc++ wrote:
Thanks for the review. I attached the updated patch.
Can you commit this for me or point me to what I should do next? This is my
first contribution here.
I was about to do this, but .
On 03/03/21 20:26 +0100, Moritz Sichert via Libstdc++ wrote:
Thanks for the review. I attached the updated patch.
Can you commit this for me or point me to what I should do next? This is my
first contribution here.
I was about to do this, but ...
+namespace test_ns
+{
+ struct A {};
+ tem
Quick reminder: Can you (or anyone) please commit this? The updated patch is
attached in the last email.
Best,
Moritz
Am 03.03.21 um 20:26 schrieb Moritz Sichert:
Thanks for the review. I attached the updated patch.
Can you commit this for me or point me to what I should do next? This is my
om 9f9858c24519bcea903de477a37b31eed09725c1 Mon Sep 17 00:00:00 2001
From: Moritz Sichert
Date: Wed, 3 Mar 2021 18:14:28 +0100
Subject: [PATCH] libstdc++: Avoid accidental ADL when calling
make_reverse_iterator
std::ranges::reverse_view uses make_reverse_iterator in its
implementation as describe
On Wed, 3 Mar 2021, Moritz Sichert via Libstdc++ wrote:
> std::ranges::reverse_view uses make_reverse_iterator in its
> implementation as described in [range.reverse.view]. This accidentally
> allows ADL as an unqualified name is used in the call. According to
> [contents], however, this should be
,
Moritz
From f9aaf991c75047f83f12a98311cb62278c32dcda Mon Sep 17 00:00:00 2001
From: Moritz Sichert
Date: Wed, 3 Mar 2021 18:14:28 +0100
Subject: [PATCH] libstdc++: Avoid accidental ADL when calling
make_reverse_iterator
std::ranges::reverse_view uses make_reverse_iterator in its
implementation as
