Re: [PATCH] libstdc++: Add comments to __unicode::_Utf_iterator

2025-07-16 Thread Tomasz Kaminski
On Wed, Jul 16, 2025 at 2:06 PM Jonathan Wakely wrote: > On Wed, 16 Jul 2025 at 12:30, Tomasz Kaminski wrote: > > > > > > > > > > On Wed, Jul 16, 2025 at 12:05 PM Jonathan Wakely > wrote: > >> > >> Add comments documenting what it does and how it does it. > >> > >> Also reorder the if-else in o

Re: [PATCH] libstdc++: Add comments to __unicode::_Utf_iterator

2025-07-16 Thread Jonathan Wakely
On Wed, 16 Jul 2025 at 12:30, Tomasz Kaminski wrote: > > > > > On Wed, Jul 16, 2025 at 12:05 PM Jonathan Wakely wrote: >> >> Add comments documenting what it does and how it does it. >> >> Also reorder the if-else in operator++ so that we check whether to >> iterate over code units in the local b

Re: [PATCH] libstdc++: Add comments to __unicode::_Utf_iterator

2025-07-16 Thread Tomasz Kaminski
On Wed, Jul 16, 2025 at 12:05 PM Jonathan Wakely wrote: > Add comments documenting what it does and how it does it. > > Also reorder the if-else in operator++ so that we check whether to > iterate over code units in the local buffer before checking whether to > refill that buffer. That seems the

[PATCH] libstdc++: Add comments to __unicode::_Utf_iterator

2025-07-16 Thread Jonathan Wakely
Add comments documenting what it does and how it does it. Also reorder the if-else in operator++ so that we check whether to iterate over code units in the local buffer before checking whether to refill that buffer. That seems the more natural way to structure the function. libstdc++-v3/ChangeLog