Re: [PATCH] libsanitizer: fix SIGSEGV in fopen64 interceptor

2020-11-19 Thread Martin Liška
On 11/20/20 8:44 AM, Vyacheslav Barinov wrote: Hello, Okay, I proposed this check to upstream [1] and it has already been accepted. Hello. Great. Please commit it to the llvm-project upstream and I'll make then the patch cherry-pick. We can either apply the fix or postpone it until next syn

Re: [PATCH] libsanitizer: fix SIGSEGV in fopen64 interceptor

2020-11-19 Thread Vyacheslav Barinov via Gcc-patches
Hello, Okay, I proposed this check to upstream [1] and it has already been accepted. We can either apply the fix or postpone it until next sync with upstream. Anyway the bug doesn't seem so bad if we were the only team who faced it during all this time. Best Regards, Vyacheslav Barinov [1]: htt

Re: [PATCH] libsanitizer: fix SIGSEGV in fopen64 interceptor

2020-11-19 Thread Martin Liška
On 11/19/20 12:28 PM, Slava Barinov via Gcc-patches wrote: Null pointer in path argument leads to SIGSEGV in interceptor. Hello. I can't see we ever had the null check in master. I don't this it was lost during a merge from master. Why do we need the hunk? Thanks, Martin libsanitizer/Chang

[PATCH] libsanitizer: fix SIGSEGV in fopen64 interceptor

2020-11-19 Thread Slava Barinov via Gcc-patches
Null pointer in path argument leads to SIGSEGV in interceptor. libsanitizer/ChangeLog: * sanitizer_common/sanitizer_common_interceptors.inc: Check path for null before dereference in fopen64 interceptor. --- Notes: Apparently check has been lost during merge from upstream li