Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-16 Thread Rainer Orth
Hi Jakub, >> fair enough. What about the gcc-9 branch by then? I expect there will >> be at least one more release from that one, too? > > Ok, but please do it in order (i.e. trunk, then 10+9+8 (if you want 8 too)). that's been the plan: I want to avoid older releases to have fixes missing in n

Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-16 Thread Jakub Jelinek via Gcc-patches
On Thu, Jul 16, 2020 at 10:44:21AM +0200, Rainer Orth wrote: > Hi Jakub, > > >> I may still be mistaken, but all this suggests that Linux might be > >> playing games with ESP and UESP, while Solaris and NetBSD (see below) > >> keep them separate, but in the end UESP is the register to use. > > > >

Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-16 Thread Rainer Orth
Hi Jakub, >> I may still be mistaken, but all this suggests that Linux might be >> playing games with ESP and UESP, while Solaris and NetBSD (see below) >> keep them separate, but in the end UESP is the register to use. > > I think what matters more is > kernel/signal.c and ia32/ia32_signal.c doin

Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-15 Thread Jakub Jelinek via Gcc-patches
On Wed, Jul 15, 2020 at 03:06:18PM +0200, Rainer Orth wrote: > I must admit I missed that in that terrible nested maze of #ifdef's > compiler-rt uses. > > > I mean, while the ifndef/define change is guarded by #if SANITIZER_SOLARIS, > > the last changed line is not. I'm afraid I don't know if > >

Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-15 Thread Rainer Orth
Hi Jakub, > On Tue, Jul 14, 2020 at 02:32:57PM +0200, Rainer Orth wrote: >> The latest Solaris 11.4/x86 update uncovered a libsanitizer bug that >> caused one test to FAIL for 32-bit: >> >> +FAIL: c-c++-common/asan/null-deref-1.c -O0 output pattern test >> +FAIL: c-c++-common/asan/null-deref-1

Re: [PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-14 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 14, 2020 at 02:32:57PM +0200, Rainer Orth wrote: > The latest Solaris 11.4/x86 update uncovered a libsanitizer bug that > caused one test to FAIL for 32-bit: > > +FAIL: c-c++-common/asan/null-deref-1.c -O0 output pattern test > +FAIL: c-c++-common/asan/null-deref-1.c -O1 output p

[PATCH] libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

2020-07-14 Thread Rainer Orth
The latest Solaris 11.4/x86 update uncovered a libsanitizer bug that caused one test to FAIL for 32-bit: +FAIL: c-c++-common/asan/null-deref-1.c -O0 output pattern test +FAIL: c-c++-common/asan/null-deref-1.c -O1 output pattern test +FAIL: c-c++-common/asan/null-deref-1.c -O2 output patte