Re: [PATCH] libibery/hashtab: add new functions

2020-08-19 Thread Martin Liška
On 8/18/20 1:38 AM, Ian Lance Taylor wrote: I guess I'm not sure why either of these belong in libiberty. htab_insert can be written elsewhere as needed. And while perhaps some sort of stats API would be reasonable, I don't think it should be something that prints values to a FILE. Understood.

Re: [PATCH] libibery/hashtab: add new functions

2020-08-17 Thread Ian Lance Taylor via Gcc-patches
On Mon, Aug 17, 2020 at 7:06 AM Martin Liška wrote: > > Adding libiberty maintainer to CC. I guess I'm not sure why either of these belong in libiberty. htab_insert can be written elsewhere as needed. And while perhaps some sort of stats API would be reasonable, I don't think it should be someth

Re: [PATCH] libibery/hashtab: add new functions

2020-08-17 Thread Martin Liška
Adding libiberty maintainer to CC. On 8/17/20 4:03 PM, Martin Liška wrote: Hey. I'm working on bintuils where I would like to port a hash table implementation in gas/hash.[ch] to libiberty one. But it would be handy for me to add 2 new functions. Thoughts? Thanks, Martin include/ChangeLog:

[PATCH] libibery/hashtab: add new functions

2020-08-17 Thread Martin Liška
Hey. I'm working on bintuils where I would like to port a hash table implementation in gas/hash.[ch] to libiberty one. But it would be handy for me to add 2 new functions. Thoughts? Thanks, Martin include/ChangeLog: * hashtab.h (htab_insert): New function. (htab_print_statisti