Re: [PATCH] libgomp: start using LIKELY/UNLIKELY macros

2022-05-25 Thread Jakub Jelinek via Gcc-patches
On Wed, May 25, 2022 at 03:13:09PM +0200, Martin Liška wrote: > Btw. I noticed one discrepancy: > > ./libgomp/loop_ull.c: > > /* Cheap overflow protection. */ > if (__builtin_expect ((nthreads | ws->chunk_size_ull) > < 1ULL << (sizeof (gomp_ull

Re: [PATCH] libgomp: start using LIKELY/UNLIKELY macros

2022-05-25 Thread Martin Liška
On 5/25/22 13:55, Jakub Jelinek wrote: > On Wed, May 25, 2022 at 01:52:46PM +0200, Martin Liška wrote: >> Similarly to g:22d9c8802add09a93308319fc37dd3a0f1125393, I would like to use >> {UN,}LIKELY macros in libgomp. If the community is fine, I'm planning doing >> the same in other GCC's libraries.

Re: [PATCH] libgomp: start using LIKELY/UNLIKELY macros

2022-05-25 Thread Jakub Jelinek via Gcc-patches
On Wed, May 25, 2022 at 01:52:46PM +0200, Martin Liška wrote: > Similarly to g:22d9c8802add09a93308319fc37dd3a0f1125393, I would like to use > {UN,}LIKELY macros in libgomp. If the community is fine, I'm planning doing > the same in other GCC's libraries. I must say I prefer __builtin_expect over

[PATCH] libgomp: start using LIKELY/UNLIKELY macros

2022-05-25 Thread Martin Liška
Similarly to g:22d9c8802add09a93308319fc37dd3a0f1125393, I would like to use {UN,}LIKELY macros in libgomp. If the community is fine, I'm planning doing the same in other GCC's libraries. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin