Re: [PATCH] libgomp: fix hang on fatal error

2022-10-19 Thread Jakub Jelinek via Gcc-patches
On Wed, Oct 19, 2022 at 03:27:52PM +0200, Jakub Jelinek via Gcc-patches wrote: > > --- a/libgomp/error.c > > +++ b/libgomp/error.c > > @@ -77,7 +77,7 @@ void > > gomp_vfatal (const char *fmt, va_list list) > > { > >gomp_verror (fmt, list); > > - exit (EXIT_FAILURE); > > + abort (); > > } >

Re: [PATCH] libgomp: fix hang on fatal error

2022-10-19 Thread Jakub Jelinek via Gcc-patches
On Fri, Oct 14, 2022 at 06:04:06PM +0100, Andrew Stubbs wrote: > This patch fixes a problem in which fatal errors inside mutex-locked regions > (i.e. basically anything in the plugin) will cause it to hang up trying to > take the lock to clean everything up. > > Using abort() instead of exit(1) by

[PATCH] libgomp: fix hang on fatal error

2022-10-14 Thread Andrew Stubbs
This patch fixes a problem in which fatal errors inside mutex-locked regions (i.e. basically anything in the plugin) will cause it to hang up trying to take the lock to clean everything up. Using abort() instead of exit(1) bypasses the atexit handlers and solves the problem. OK for mainline?