Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-08 Thread y2s1982 . via Gcc-patches
Hello On Wed, Jul 8, 2020 at 5:08 AM Jakub Jelinek wrote: > On Tue, Jul 07, 2020 at 02:52:37PM -0400, y2s1982 . via Gcc-patches wrote: > > I have re-read the documentation trying to find a different solution. > > In particular, ompd_device_initialize states that > > ompd_device_t kind, ompd_size

Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-08 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 07, 2020 at 02:52:37PM -0400, y2s1982 . via Gcc-patches wrote: > I have re-read the documentation trying to find a different solution. > In particular, ompd_device_initialize states that > ompd_device_t kind, ompd_size_t sizeof_id, and void *id represents > a device identifier. To dig f

Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-07 Thread y2s1982 . via Gcc-patches
Hello, On Tue, Jul 7, 2020 at 7:46 AM Jakub Jelinek wrote: > On Tue, Jul 07, 2020 at 07:38:13AM -0400, y2s1982 . wrote: > > > I have no idea what this function is doing, but e.g. from aliasing > point of > > > view trying to access something as short/int/long long is dangerous, > and > > > there

Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-07 Thread Jakub Jelinek via Gcc-patches
On Tue, Jul 07, 2020 at 07:38:13AM -0400, y2s1982 . wrote: > > I have no idea what this function is doing, but e.g. from aliasing point of > > view trying to access something as short/int/long long is dangerous, and > > there might be alignment implications too. > > > > This function is used in om

Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-07 Thread y2s1982 . via Gcc-patches
Hello Jakub, Thank you for the review. I had some questions. On Tue, Jul 7, 2020 at 4:13 AM Jakub Jelinek wrote: > On Fri, Jul 03, 2020 at 10:43:55PM -0400, y2s1982 via Gcc-patches wrote: > > > + switch (id_size) > > +{ > > +case 1: > > + *output_id = (_gompd_device_id) *((__UINT8

Re: [PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-07 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 03, 2020 at 10:43:55PM -0400, y2s1982 via Gcc-patches wrote: > This patch adds OMPD functions defined in 5.5.2 of the OpenMP 5.0 API > documentation. It adds per-process and per-device functions, defines > related handle data types, and adds a helper function for storing device > id. >

[PATCH] libgomp: Add OMPD process functions and datatypes.

2020-07-03 Thread y2s1982 via Gcc-patches
This patch adds OMPD functions defined in 5.5.2 of the OpenMP 5.0 API documentation. It adds per-process and per-device functions, defines related handle data types, and adds a helper function for storing device id. 2020-07-03 Tony Sim libgomp/ChangeLog: * Makefile.am (libgompd_la_OBJ