Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-14 Thread y2s1982 via Gcc-patches
Hello Jakub, I remember now why I had gompd_env_info as a global variable. It was meant to be in libgomp.so.1. It was mistakenly placed in libgompd.h; it was supposed to be in libgomp.h. I am having trouble connecting the dots and need help. To expose a variable, such as the gompd_env_info, so th

[PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-14 Thread y2s1982 via Gcc-patches
This patch adds Address Space Information function implementations as defined in section 5.5.4 of OpenMP API Specification 5.0. It also defines a struct that stores various information used by OMPD. This patch addressed all feedbacks. 2020-07-14 Tony Sim libgomp/ChangeLog: * Makefile

Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-14 Thread y2s1982 via Gcc-patches
Hello Jakub, Thank you for the detailed information. I will make those changes right away. Cheers, Tony Sim On Tue, Jul 14, 2020 at 5:57 AM Jakub Jelinek wrote: > On Thu, Jul 09, 2020 at 07:01:00PM -0400, y2s1982 via Gcc-patches wrote: > > --- a/libgomp/libgompd.h > > +++ b/libgomp/libgompd.h

Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-14 Thread Jakub Jelinek via Gcc-patches
On Thu, Jul 09, 2020 at 07:01:00PM -0400, y2s1982 via Gcc-patches wrote: > --- a/libgomp/libgompd.h > +++ b/libgomp/libgompd.h > @@ -47,4 +47,19 @@ typedef struct _ompd_aspace_handle { >ompd_size_t ref_count; > } ompd_address_space_handle_t; > > +struct gompd_env > +{ > + /* TODO: when the

[PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-09 Thread y2s1982 via Gcc-patches
This patch adds Address Space Information function implementations as defined in section 5.5.4 of OpenMP API Specification 5.0. It also defines a struct that stores various information used by OMPD. 2020-07-09 Tony Sim libgomp/ChangeLog: * Makefile.am (libgompd_la_OBJECTS): Add ompd-a

Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-09 Thread Jakub Jelinek via Gcc-patches
On Wed, Jul 08, 2020 at 07:53:23PM -0400, y2s1982 . wrote: > I do remember, though I obviously understood wrongly. Sorry about that. > I had assumed it might have something to do with ICV but didn't realize it > would also > apply to other variables. In all honesty, I was looking for _OPENMP macro;

Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-08 Thread y2s1982 . via Gcc-patches
Hello Jakub, Thank you again for detailed feedback. I had few questions. On Wed, Jul 8, 2020 at 4:42 PM Jakub Jelinek wrote: > On Wed, Jul 08, 2020 at 03:30:35PM -0400, y2s1982 wrote: > > +ompd_rc_t > > +ompd_get_omp_version (ompd_address_space_handle_t *address_space, > > + o

Re: [PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-08 Thread Jakub Jelinek via Gcc-patches
On Wed, Jul 08, 2020 at 03:30:35PM -0400, y2s1982 wrote: > +ompd_rc_t > +ompd_get_omp_version (ompd_address_space_handle_t *address_space, > + ompd_word_t *omp_version) > +{ > + if (omp_version == NULL) > +return ompd_rc_bad_input; > + if (address_space == NULL) > +retur

[PATCH] libgomp: Add OMPD Address Space Information functions.

2020-07-08 Thread y2s1982 via Gcc-patches
This patch adds Address Space Information function implementations as defined in section 5.5.4 of OpenMP API Specification 5.0. 2020-07-08 Tony Sim libgomp/ChangeLog: * Makefile.am (libgompd_la_OBJECTS): Add ompd-addr.c. * Makefile.in: Regenerate. * ompd-addr.c: New fi