Re: [PATCH] libgccjit: Support signed char flag

2024-11-20 Thread David Malcolm
On Thu, 2024-02-22 at 15:29 -0500, Antoni Boucher wrote: > Thanks for the review and idea. Thanks for the updated patch; sorry about the delay in reviewing. > > Here's the updated patch. I added a test, but I could not set - > fsigned- > char as this is not an option accepted by the jit frontend

Re: [PATCH] libgccjit: Support signed char flag

2024-02-22 Thread Antoni Boucher
> promotes a negative char to a signed int, and then returns the result > as an int?  Presumably if we're erroneously forcing "char" to be > unsigned, the int will be in the range 0x80 to 0xff, rather that > being > negative. > > Dave > From 57d4bd695bcb16c54ec

Re: [PATCH] libgccjit: Support signed char flag

2024-01-09 Thread David Malcolm
On Thu, 2023-12-21 at 08:42 -0500, Antoni Boucher wrote: > Hi. > This patch adds support for the -fsigned-char flag. Thanks. The patch looks correct to me. > I'm not sure how to test it since I stumbled upon this bug when I > found > this other bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=1

[PATCH] libgccjit: Support signed char flag

2023-12-21 Thread Antoni Boucher
From 45719be81ab71983ab10ecb67139eaf02955e4db Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Mon, 3 Oct 2022 19:11:39 -0400 Subject: [PATCH] libgccjit: Support signed char flag gcc/jit/ChangeLog: * dummy-frontend.cc (jit_langhook_init): Send flag_signed_char argument to build_common_tree_nodes. --- gc