Re: [PATCH] libgccjit: Add support for setting the comment ident

2024-02-22 Thread Antoni Boucher
() > > +{ > > +  delete[] m_ident; > > m_ident is allocated above using xstrdup, so it must be cleaned up > with > "free"; I don't think it's safe to use "delete[]" here. > > [...snip...] > > > +/* Implementation of recording::

Re: [PATCH] libgccjit: Add support for setting the comment ident

2024-01-05 Thread David Malcolm
On Fri, 2024-01-05 at 12:09 -0500, Antoni Boucher wrote: > Hi. > This patch adds support for setting the comment ident (analogous to > #ident "comment" in C). > Thanks for the review. Thanks for the patch. This may sound like a silly question, but what does #ident do and what is it used for? FWI

[PATCH] libgccjit: Add support for setting the comment ident

2024-01-05 Thread Antoni Boucher
Hi. This patch adds support for setting the comment ident (analogous to #ident "comment" in C). Thanks for the review. From 1af4e77540001cce8c30e86040c1da785e435810 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Fri, 27 Oct 2023 17:36:03 -0400 Subject: [PATCH] libgccjit: Add s