Re: [PATCH] libgcc/mkmap-symver: support skip_underscore (PR74748)

2016-11-19 Thread Jeff Law
On 11/19/2016 02:45 AM, Thomas Petazzoni wrote: All symbols in Blackfin are prepended with an underscore, so we're pretty much guaranteed there is one, and we precisely want to get rid of this prepended underscore. So I'd say it's good enough to get rid of the first character, without checking if

Re: [PATCH] libgcc/mkmap-symver: support skip_underscore (PR74748)

2016-11-19 Thread Thomas Petazzoni
Hello, On Thu, 17 Nov 2016 14:08:34 -0700, Jeff Law wrote: > AFAICT this skips the first character regardless of whether or not it is > an underscore when skip_underscore is in effect, right. Correct. > Is that intentional? All symbols in Blackfin are prepended with an underscore, so we're p

Re: [PATCH] libgcc/mkmap-symver: support skip_underscore (PR74748)

2016-11-17 Thread Jeff Law
On 11/06/2016 09:32 AM, Waldemar Brodkorb wrote: Hi, Some platforms, such as Blackfin, have a special prefix for assembly symbols as opposed to C symbols. For this reason, a function named "foo()" in C will in fact be visible as a symbol called "_foo" in the ELF binary. The current linker versi

[PATCH] libgcc/mkmap-symver: support skip_underscore (PR74748)

2016-11-06 Thread Waldemar Brodkorb
Hi, Some platforms, such as Blackfin, have a special prefix for assembly symbols as opposed to C symbols. For this reason, a function named "foo()" in C will in fact be visible as a symbol called "_foo" in the ELF binary. The current linker version script logic in libgcc doesn't take into account