Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-28 Thread Steve Ellcey
On Thu, 2016-01-28 at 14:59 -0500, David Malcolm wrote: > On Thu, 2016-01-28 at 14:48 -0500, David Malcolm wrote: > > On Thu, 2016-01-28 at 11:12 -0800, Steve Ellcey wrote: > > > David, > > > > > > This patch has broken the top-of-tree glibc build > > > > Bother; sorry. FWIW, I'm about to get on

Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-28 Thread David Malcolm
On Thu, 2016-01-28 at 14:48 -0500, David Malcolm wrote: > On Thu, 2016-01-28 at 11:12 -0800, Steve Ellcey wrote: > > David, > > > > This patch has broken the top-of-tree glibc build > > Bother; sorry. FWIW, I'm about to get on a plane (for FOSDEM), so > I'm > not in a great position to tackle th

Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-28 Thread David Malcolm
On Thu, 2016-01-28 at 11:12 -0800, Steve Ellcey wrote: > David, > > This patch has broken the top-of-tree glibc build Bother; sorry. FWIW, I'm about to get on a plane (for FOSDEM), so I'm not in a great position to tackle this yet. > I get an error on an > undef that is supposed to be protected

Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-28 Thread Steve Ellcey
David, This patch has broken the top-of-tree glibc build. I get an error on an undef that is supposed to be protected by Pragmas. It happens when compiling intl/plural.c in glibc. I created a preprocessed source file but when I compile it, the error doesn't happen. I will try to create a small

Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-28 Thread Jakub Jelinek
On Sun, Jan 17, 2016 at 09:09:53AM -0500, David Malcolm wrote: > libcpp/ChangeLog: > PR preprocessor/69126 > * directives.c (destringize_and_run): Add expansion_loc param; use > it when handling unexpanded pragmas to fixup the locations of the > synthesized tokens. This cha

Re: [PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-27 Thread Jeff Law
On 01/17/2016 07:09 AM, David Malcolm wrote: Our code for handling the "_Pragma" builtin macro is implemented in libcpp/directives.c:destringize_and_run. It handles _Pragma by creating a one-line buffer containing the _Pragma content, then sending it to do_pragma, which tokenizes it and handles

[PATCH] libcpp: use better locations for _Pragma tokens (preprocessor/69126)

2016-01-17 Thread David Malcolm
Our code for handling the "_Pragma" builtin macro is implemented in libcpp/directives.c:destringize_and_run. It handles _Pragma by creating a one-line buffer containing the _Pragma content, then sending it to do_pragma, which tokenizes it and handles the input as if it were spelled as #pragma.