Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-21 Thread Kewen.Lin via Gcc-patches
on 2021/9/21 下午2:16, Richard Biener wrote: > On Tue, Sep 21, 2021 at 4:09 AM Kewen.Lin wrote: >> >> Hi Richi, >> >> Thanks for the review! >> >> on 2021/9/17 下午6:04, Richard Biener wrote: >>> On Fri, Sep 17, 2021 at 12:03 PM Richard Biener >>> wrote: On Fri, Sep 17, 2021 at 11:43 AM Kew

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-20 Thread Richard Biener via Gcc-patches
On Tue, Sep 21, 2021 at 4:09 AM Kewen.Lin wrote: > > Hi Richi, > > Thanks for the review! > > on 2021/9/17 下午6:04, Richard Biener wrote: > > On Fri, Sep 17, 2021 at 12:03 PM Richard Biener > > wrote: > >> > >> On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > >>> > >>> Hi, > >>> > >>> When cha

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-20 Thread Kewen.Lin via Gcc-patches
Hi Richi, Thanks for the review! on 2021/9/17 下午6:04, Richard Biener wrote: > On Fri, Sep 17, 2021 at 12:03 PM Richard Biener > wrote: >> >> On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: >>> >>> Hi, >>> >>> When changing target_info with bitfield, I happened to find this >>> inconsistent st

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 12:03 PM Richard Biener wrote: > > On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > > > > Hi, > > > > When changing target_info with bitfield, I happened to find this > > inconsistent streaming in and out. We have the streaming in: > > > > bp_pack_value (&bp,

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > > Hi, > > When changing target_info with bitfield, I happened to find this > inconsistent streaming in and out. We have the streaming in: > > bp_pack_value (&bp, info->inlinable, 1); > bp_pack_value (&bp, false, 1); >

[PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Kewen.Lin via Gcc-patches
Hi, When changing target_info with bitfield, I happened to find this inconsistent streaming in and out. We have the streaming in: bp_pack_value (&bp, info->inlinable, 1); bp_pack_value (&bp, false, 1); bp_pack_value (&bp, info->fp_expressions, 1); while the streami