Re: [PATCH] ipa: fix bit CPP when combined with IPA bit CP

2020-08-13 Thread Martin Liška
On 8/12/20 7:03 PM, Martin Liška wrote: There's an updated version of the patch that is approved by Honza. I'm going to install it (and I'll backport it as well). Martin And there's one obvious fix that aligns code in ipcp_bits_lattice::set_to_constant with ipcp_bits_lattice::meet_with_1. P

Re: [PATCH] ipa: fix bit CPP when combined with IPA bit CP

2020-08-12 Thread Martin Liška
] ipa: fix bit CPP when combined with IPA bit CP As mentioned in the PR, let's consider the following example: int __attribute__((noinline)) foo(int arg) { if (arg == 3) return 1; if (arg == 4) return 123; __builtin_unreachable (); } during WPA we find all calls of the func

[PATCH] ipa: fix bit CPP when combined with IPA bit CP

2020-08-12 Thread Martin Liška
Hello. First, I must confess I'm not familiar with bit constant propagation. However, I learnt something during debugging session related to this PR. As mentioned in the PR, let's consider the following example: int __attribute__((noinline)) foo(int arg) { if (arg == 3) return 1; if (