Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-28 Thread Josef Melcr
Dne 28. 04. 25 v 10:58 Jakub Jelinek napsal(a): On Sun, Apr 27, 2025 at 11:56:21AM +0200, Josef Melcr wrote: * builtin-attrs.def (0): New int list. This is just weird. Write * builtin-attrs.def: Add DEF_LIST_INT_INT (0,2). ? +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 0) +DEF_CALLBACK_

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-28 Thread Jakub Jelinek
On Sun, Apr 27, 2025 at 11:56:21AM +0200, Josef Melcr wrote: > * builtin-attrs.def (0): New int list. This is just weird. Write * builtin-attrs.def: Add DEF_LIST_INT_INT (0,2). ? > +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 0) > +DEF_CALLBACK_ATTRIBUTE(GOMP, 1, 2) > +DEF_CALLBACK_ATTRIBUTE(O

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Josef Melcr
Lambdas have crossed my mind, but I have not yet had the time to look thoroughly into their implementation and the issues they face. I do plan to look into them once I am done with some incremental improvements for the attribute and callback edges, as lambdas seem like a good candidate for this

Re: [PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2025 at 2:58 AM Josef Melcr wrote: > > This patch enables constant propagation to outlined OpenMP kernels and > improves support for optimizing callback functions in general. It > implements the attribute 'callback' as found in clang, though argument > numbering is a bit different,

[PATCH] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-04-27 Thread Josef Melcr
This patch enables constant propagation to outlined OpenMP kernels and improves support for optimizing callback functions in general. It implements the attribute 'callback' as found in clang, though argument numbering is a bit different, as described below. The title says OpenMP, but it can be used