Re: [PATCH] internal-fn: Avoid dropping the lhs of some calls [PR94941]

2020-05-04 Thread Jakub Jelinek via Gcc-patches
On Mon, May 04, 2020 at 03:03:01PM +0200, Richard Biener wrote: > We seem to have inconsistent use of rtx_equal_p vs. pointer comparison > of target and ops[0].value - is that because some are eventually MEMs > and some (targets?) are always registers? Of course I prefer the > cheaper != compariso

Re: [PATCH] internal-fn: Avoid dropping the lhs of some calls [PR94941]

2020-05-04 Thread Richard Biener via Gcc-patches
On Mon, May 4, 2020 at 2:55 PM Richard Sandiford wrote: > > create_output_operand coerces an output operand to the insn's > predicates, using a suggested rtx location if convenient. > But if that rtx location is actually required rather than > optional, the builder of the insn has to emit a move a

[PATCH] internal-fn: Avoid dropping the lhs of some calls [PR94941]

2020-05-04 Thread Richard Sandiford
create_output_operand coerces an output operand to the insn's predicates, using a suggested rtx location if convenient. But if that rtx location is actually required rather than optional, the builder of the insn has to emit a move afterwards. (We could instead add a new interface that does this au