Re: [PATCH] improve note location and refactor warn_uninit

2021-09-02 Thread Martin Sebor via Gcc-patches
On 8/27/21 5:23 PM, Jeff Law wrote: On 8/26/2021 1:30 PM, Martin Sebor via Gcc-patches wrote: On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble gett

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-27 Thread Jeff Law via Gcc-patches
On 8/26/2021 1:30 PM, Martin Sebor via Gcc-patches wrote: On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the not

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-27 Thread Jeff Law via Gcc-patches
On 8/26/2021 1:00 AM, Richard Biener via Gcc-patches wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable. I said I'd look into it, and so I did. T

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-27 Thread Martin Sebor via Gcc-patches
Hello Nathan & Joern, Richard has asked me to give you a heads up that we will be enabling an informational note for all instances of the GCC -Wuninitialized warning. You added the helpful note pretty much exactly 15 years ago to the day (in http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=11656

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-27 Thread Richard Biener via Gcc-patches
On August 27, 2021 5:20:57 PM GMT+02:00, Martin Sebor wrote: >On 8/27/21 12:23 AM, Richard Biener wrote: >> On Thu, Aug 26, 2021 at 9:30 PM Martin Sebor wrote: >>> >>> On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: > On Wed, Aug 25, 2021 at 10:03 PM Ma

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-27 Thread Martin Sebor via Gcc-patches
On 8/27/21 12:23 AM, Richard Biener wrote: On Thu, Aug 26, 2021 at 9:30 PM Martin Sebor wrote: On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble get

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-26 Thread Richard Biener via Gcc-patches
On Thu, Aug 26, 2021 at 9:30 PM Martin Sebor wrote: > > On 8/26/21 10:38 AM, Martin Sebor wrote: > > On 8/26/21 1:00 AM, Richard Biener wrote: > >> On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: > >>> > >>> Richard, some time ago you mentioned you'd had trouble getting > >>> -Wuninitialized

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-26 Thread Martin Sebor via Gcc-patches
On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable.  I said I'd look int

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-26 Thread Martin Sebor via Gcc-patches
On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable. I said I'd look into it, and so I did. The attached patch si

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-26 Thread Richard Biener via Gcc-patches
On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: > > Richard, some time ago you mentioned you'd had trouble getting > -Wuninitialized to print the note pointing to the uninitialized > variable. I said I'd look into it, and so I did. The attached > patch simplifies the warn_uninit() function

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Martin Sebor via Gcc-patches
On 8/25/21 5:00 PM, Jeff Law wrote: On 8/25/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable.  I said I'd look into it, and so I did.  The attached patch sim

Re: [PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Jeff Law via Gcc-patches
On 8/25/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable.  I said I'd look into it, and so I did.  The attached patch simplifies the warn_uninit() function t

[PATCH] improve note location and refactor warn_uninit

2021-08-25 Thread Martin Sebor via Gcc-patches
Richard, some time ago you mentioned you'd had trouble getting -Wuninitialized to print the note pointing to the uninitialized variable. I said I'd look into it, and so I did. The attached patch simplifies the warn_uninit() function to get rid of some redundant cruft: besides a few pointless nul