Re: [PATCH] implement -Wformat-diag, v2

2019-06-22 Thread Ian Lance Taylor
On Fri, Jun 21, 2019 at 3:52 PM Martin Sebor wrote: > > Most of the rest seem justified to me and worth cleaning up. Let > me know if you agree and if you'd like my help with it. Thanks. I sent https://golang.org/cl/183437 and https://golang.org/cl/183497 to take care of these. Ian

Re: [PATCH] implement -Wformat-diag, v2

2019-06-21 Thread Martin Sebor
On 6/21/19 4:16 PM, Ian Lance Taylor wrote: On Wed, Jun 19, 2019 at 12:49 PM Martin Sebor wrote: gcc-wformat-diag-checker.diff gcc/c-family/ChangeLog: * c-format.c (function_format_info::format_type): Adjust type. (function_format_info::is_raw): New member. (decode_format

Re: [PATCH] implement -Wformat-diag, v2

2019-06-21 Thread Ian Lance Taylor via gcc-patches
On Wed, Jun 19, 2019 at 12:49 PM Martin Sebor wrote: > > > gcc-wformat-diag-checker.diff > > gcc/c-family/ChangeLog: > > * c-format.c (function_format_info::format_type): Adjust type. > (function_format_info::is_raw): New member. > (decode_for

Re: [PATCH] implement -Wformat-diag, v2

2019-06-19 Thread Martin Sebor
On 6/19/19 10:46 AM, Jeff Law wrote: On 6/18/19 1:21 PM, Martin Sebor wrote: On 6/18/19 12:59 PM, Jeff Law wrote: On 5/22/19 10:42 AM, Martin Sebor wrote: Attached is a revised implementation of the -Wformat-diag checker incorporating the feedback I got on the first revision. Martin gcc-wfor

Re: [PATCH] implement -Wformat-diag, v2

2019-06-19 Thread Jeff Law
On 6/18/19 1:21 PM, Martin Sebor wrote: > On 6/18/19 12:59 PM, Jeff Law wrote: >> On 5/22/19 10:42 AM, Martin Sebor wrote: >>> Attached is a revised implementation of the -Wformat-diag checker >>> incorporating the feedback I got on the first revision. >>> >>> Martin >>> >>> gcc-wformat-diag-checke

Re: [PATCH] implement -Wformat-diag, v2

2019-06-18 Thread Martin Sebor
On 6/18/19 12:59 PM, Jeff Law wrote: On 5/22/19 10:42 AM, Martin Sebor wrote: Attached is a revised implementation of the -Wformat-diag checker incorporating the feedback I got on the first revision. Martin gcc-wformat-diag-checker.diff gcc/c-family/ChangeLog: * c-format.c (function_

Re: [PATCH] implement -Wformat-diag, v2

2019-06-18 Thread Jeff Law
On 5/22/19 10:42 AM, Martin Sebor wrote: > Attached is a revised implementation of the -Wformat-diag checker > incorporating the feedback I got on the first revision. > > Martin > > gcc-wformat-diag-checker.diff > > gcc/c-family/ChangeLog: > > * c-format.c (function_format_info::format_ty

PING 2: [PATCH] implement -Wformat-diag, v2

2019-06-18 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01513.html On 6/11/19 7:31 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01513.html On 5/22/19 10:42 AM, Martin Sebor wrote: Attached is a revised implementation of the -Wformat-diag checker incorporating the fee

PING: [PATCH] implement -Wformat-diag, v2

2019-06-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01513.html On 5/22/19 10:42 AM, Martin Sebor wrote: Attached is a revised implementation of the -Wformat-diag checker incorporating the feedback I got on the first revision. Martin

[PATCH] implement -Wformat-diag, v2

2019-05-22 Thread Martin Sebor
Attached is a revised implementation of the -Wformat-diag checker incorporating the feedback I got on the first revision. Martin gcc/c-family/ChangeLog: * c-format.c (function_format_info::format_type): Adjust type. (function_format_info::is_raw): New member. (decode_format_type): Adjust sign