Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Segher Boessenkool
On Thu, Dec 31, 2020 at 04:39:52PM +, Richard Sandiford wrote: > Segher Boessenkool writes: > > It isn't likely that any other pass would try to create this pattern, > > but this isn't guaranteed, and such other passes do not necessarily do > > the add-the-clobber (that is specific to combine,

Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Richard Sandiford via Gcc-patches
Segher Boessenkool writes: > It isn't likely that any other pass would try to create this pattern, > but this isn't guaranteed, and such other passes do not necessarily do > the add-the-clobber (that is specific to combine, even!) Maybe fwprop > could create this insn, or something like Richard's

Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Uros Bizjak via Gcc-patches
On Thu, Dec 31, 2020 at 1:29 PM Segher Boessenkool wrote: > > Hi! > > On Thu, Dec 31, 2020 at 09:54:01AM +0100, Uros Bizjak wrote: > > On Thu, Dec 31, 2020 at 9:40 AM Segher Boessenkool > > wrote: > > > Nice. Just one thing: in principle the splitters can be used outside of > > > combine, too?

Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Segher Boessenkool
Hi! On Thu, Dec 31, 2020 at 09:54:01AM +0100, Uros Bizjak wrote: > On Thu, Dec 31, 2020 at 9:40 AM Segher Boessenkool > wrote: > > Nice. Just one thing: in principle the splitters can be used outside of > > combine, too? This can lead to insns that do not recog() then? Is > > there anything th

Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Uros Bizjak via Gcc-patches
On Thu, Dec 31, 2020 at 9:40 AM Segher Boessenkool wrote: > > Hi Uros, > > On Wed, Dec 30, 2020 at 05:44:50PM +0100, Uros Bizjak via Gcc-patches wrote: > > There is no need for combine splitters to emit insn patterns with clobbers, > > the pass is smart enough to add clobbers to patterns as necess

Re: [PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-31 Thread Segher Boessenkool
Hi Uros, On Wed, Dec 30, 2020 at 05:44:50PM +0100, Uros Bizjak via Gcc-patches wrote: > There is no need for combine splitters to emit insn patterns with clobbers, > the pass is smart enough to add clobbers to patterns as necessary. Nice. Just one thing: in principle the splitters can be used ou

[PATCH] i386: Remove unnecessary clobbers from combine splitters.

2020-12-30 Thread Uros Bizjak via Gcc-patches
There is no need for combine splitters to emit insn patterns with clobbers, the pass is smart enough to add clobbers to patterns as necessary. 2020-12-30 Uroš Bizjak gcc/ * config/i386/i386.md: Remove unnecessary clobbers from combine splitters. Bootstrapped and regression tested on x