PING: V2 [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-20 Thread H.J. Lu
On Mon, Nov 5, 2018 at 2:02 PM H.J. Lu wrote: > > Hi Richard, Jakub, > > Can you take a look at this patch? The last review from Kirill was in > June. > > Thanks. > > > H.J. > -- > There are many duplicated AVX2/AVX512 vec_dup patterns like: > > (define_insn "avx2_vec_dup" > [(set (match_operan

V2 [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-05 Thread H.J. Lu
Hi Richard, Jakub, Can you take a look at this patch? The last review from Kirill was in June. Thanks. H.J. -- There are many duplicated AVX2/AVX512 vec_dup patterns like: (define_insn "avx2_vec_dup" [(set (match_operand:VF1_128_256 0 "register_operand" "=v") (vec_duplicate:VF1_128_

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-05 Thread Uros Bizjak
On Sun, Nov 4, 2018 at 9:49 PM H.J. Lu wrote: > > > > Actually, we can achieve the same with pre-reload splitters. Please > > > > see the attached patch for a couple of examples and a fix for > > > > vbroadcastss that accesses the memory in wrong mode. > > > > > > > > > > My patch removes a bunch

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread H.J. Lu
On Sun, Nov 4, 2018 at 11:45 AM Uros Bizjak wrote: > > On Sun, Nov 4, 2018 at 8:17 PM H.J. Lu wrote: > > > > On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > > > > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace the

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread Uros Bizjak
On Sun, Nov 4, 2018 at 8:17 PM H.J. Lu wrote: > > On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > > > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread H.J. Lu
On Sun, Nov 4, 2018 at 8:41 AM Uros Bizjak wrote: > > On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is changed by > > > > avx2_test: > > .cfi_startproc >

Re: [PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-04 Thread Uros Bizjak
On Fri, Nov 2, 2018 at 6:25 PM H.J. Lu wrote: > > Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with > subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is changed by > > avx2_test: > .cfi_startproc > - vmovaps x(%rip), %xmm1 > - vbroadcastss%xmm1, %ym

[PATCH] i386: Remove duplicated AVX2/AVX512 vec_dup patterns

2018-11-02 Thread H.J. Lu
Remove duplicated AVX2/AVX512 vec_dup patterns and replace them with subreg. gcc.target/i386/avx2-vbroadcastss_ps256-1.c is changed by avx2_test: .cfi_startproc - vmovaps x(%rip), %xmm1 - vbroadcastss%xmm1, %ymm0 + vbroadcastssx(%rip), %ymm0 vmovaps %ymm