Re: [PATCH] i386: Fix aes/vaes patterns [PR114576]

2024-04-08 Thread Hongtao Liu
On Thu, Apr 4, 2024 at 4:42 PM Jakub Jelinek wrote: > > On Wed, Apr 19, 2023 at 02:40:59AM +, Jiang, Haochen via Gcc-patches > wrote: > > > > (define_insn "aesenc" > > > > - [(set (match_operand:V2DI 0 "register_operand" "=x,x") > > > > - (unspec:V2DI [(match_operand:V2DI 1 "register_

RE: [PATCH] i386: Fix aes/vaes patterns [PR114576]

2024-04-08 Thread Jiang, Haochen
> -Original Message- > From: Jakub Jelinek > Sent: Monday, April 8, 2024 9:43 PM > To: Jiang, Haochen > Cc: Hongtao Liu ; gcc-patches@gcc.gnu.org; Liu, Hongtao > ; ubiz...@gmail.com > Subject: Re: [PATCH] i386: Fix aes/vaes patterns [PR114576] > > On Mon,

Re: [PATCH] i386: Fix aes/vaes patterns [PR114576]

2024-04-08 Thread Jakub Jelinek
On Mon, Apr 08, 2024 at 12:33:39PM +, Jiang, Haochen wrote: > Sorry for the late response since I am on vacation for now. > > > As the following testcase shows, the above change was incorrect. > > > > Using aes isa for the second alternative is obviously wrong, aes is enabled > > whenever -ma

RE: [PATCH] i386: Fix aes/vaes patterns [PR114576]

2024-04-08 Thread Jiang, Haochen
Hi Jakub, Sorry for the late response since I am on vacation for now. > As the following testcase shows, the above change was incorrect. > > Using aes isa for the second alternative is obviously wrong, aes is enabled > whenever -maes is, regardless of -mavx or -mno-avx, so the above change > mea

[PATCH] i386: Fix aes/vaes patterns [PR114576]

2024-04-04 Thread Jakub Jelinek
On Wed, Apr 19, 2023 at 02:40:59AM +, Jiang, Haochen via Gcc-patches wrote: > > > (define_insn "aesenc" > > > - [(set (match_operand:V2DI 0 "register_operand" "=x,x") > > > - (unspec:V2DI [(match_operand:V2DI 1 "register_operand" "0,x") > > > - (match_operand:V2DI 2