Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-05 Thread H.J. Lu
On Sun, Aug 5, 2018 at 12:15 AM, Uros Bizjak wrote: >>> OK, but please add a comment, so in the future we will still know the >>> purpose of the magic number. >>> >> >> Like this? >> >> H.J. >> --- >> cfun->machine->max_used_stack_alignment is used to decide how stack frame >> should be aligned.

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-05 Thread Uros Bizjak
On Sun, Aug 5, 2018 at 12:48 AM, H.J. Lu wrote: > On Sat, Aug 04, 2018 at 11:48:15PM +0200, Uros Bizjak wrote: >> On Sat, Aug 4, 2018 at 9:49 PM, H.J. Lu wrote: >> > On Sat, Aug 4, 2018 at 12:09 PM, Uros Bizjak wrote: >> >> On Sat, Aug 4, 2018 at 3:59 PM, H.J. Lu wrote: >> >>> On Sat, Aug 4, 20

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread H.J. Lu
On Sat, Aug 04, 2018 at 11:48:15PM +0200, Uros Bizjak wrote: > On Sat, Aug 4, 2018 at 9:49 PM, H.J. Lu wrote: > > On Sat, Aug 4, 2018 at 12:09 PM, Uros Bizjak wrote: > >> On Sat, Aug 4, 2018 at 3:59 PM, H.J. Lu wrote: > >>> On Sat, Aug 4, 2018 at 3:42 AM, Uros Bizjak wrote: > On Fri, Aug 3

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread Uros Bizjak
On Sat, Aug 4, 2018 at 9:49 PM, H.J. Lu wrote: > On Sat, Aug 4, 2018 at 12:09 PM, Uros Bizjak wrote: >> On Sat, Aug 4, 2018 at 3:59 PM, H.J. Lu wrote: >>> On Sat, Aug 4, 2018 at 3:42 AM, Uros Bizjak wrote: On Fri, Aug 3, 2018 at 12:55 AM, H.J. Lu wrote: > We should always set cfun->ma

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread H.J. Lu
On Sat, Aug 4, 2018 at 12:09 PM, Uros Bizjak wrote: > On Sat, Aug 4, 2018 at 3:59 PM, H.J. Lu wrote: >> On Sat, Aug 4, 2018 at 3:42 AM, Uros Bizjak wrote: >>> On Fri, Aug 3, 2018 at 12:55 AM, H.J. Lu wrote: We should always set cfun->machine->max_used_stack_alignment if the maximum st

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread Uros Bizjak
On Sat, Aug 4, 2018 at 3:59 PM, H.J. Lu wrote: > On Sat, Aug 4, 2018 at 3:42 AM, Uros Bizjak wrote: >> On Fri, Aug 3, 2018 at 12:55 AM, H.J. Lu wrote: >>> We should always set cfun->machine->max_used_stack_alignment if the >>> maximum stack slot alignment may be greater than 64 bits. >>> >>> Tes

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread H.J. Lu
On Sat, Aug 4, 2018 at 3:42 AM, Uros Bizjak wrote: > On Fri, Aug 3, 2018 at 12:55 AM, H.J. Lu wrote: >> We should always set cfun->machine->max_used_stack_alignment if the >> maximum stack slot alignment may be greater than 64 bits. >> >> Tested on i686 and x86-64. OK for master and backport for

Re: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-04 Thread Uros Bizjak
On Fri, Aug 3, 2018 at 12:55 AM, H.J. Lu wrote: > We should always set cfun->machine->max_used_stack_alignment if the > maximum stack slot alignment may be greater than 64 bits. > > Tested on i686 and x86-64. OK for master and backport for GCC 8? Can you explain why 64 bits, and what this value

[PATCH] i386: Always set cfun->machine->max_used_stack_alignment

2018-08-02 Thread H.J. Lu
We should always set cfun->machine->max_used_stack_alignment if the maximum stack slot alignment may be greater than 64 bits. Tested on i686 and x86-64. OK for master and backport for GCC 8? Thanks. H.J. gcc/ PR target/86386 * config/i386/i386.c (ix86_finalize_stack_frame_