Re: [PATCH] i18n fixes in gimple-ssa-sprintf.c (take 2)

2018-03-02 Thread Jakub Jelinek
On Fri, Mar 02, 2018 at 08:42:22AM +0100, Jakub Jelinek wrote: > I've verified generated gcc.pot is the same between previous and this > patch, except for line numbers in the comments, and if I comment out > the (int) casts from dir.len in both one of fmtwarn and one of fmtwarn_n > calls, gcc prope

Re: [PATCH] i18n fixes in gimple-ssa-sprintf.c (take 2)

2018-03-02 Thread Jeff Law
On 03/02/2018 12:42 AM, Jakub Jelinek wrote: > On Thu, Mar 01, 2018 at 06:05:30PM -0700, Martin Sebor wrote: >>> --- gcc/gimple-ssa-sprintf.c.jj 2018-02-27 23:16:19.747948912 +0100 >>> +++ gcc/gimple-ssa-sprintf.c2018-03-01 21:26:37.728861287 +0100 >>> @@ -592,14 +592,12 @@ get_format_s

[PATCH] i18n fixes in gimple-ssa-sprintf.c (take 2)

2018-03-02 Thread Jakub Jelinek
On Thu, Mar 01, 2018 at 06:05:30PM -0700, Martin Sebor wrote: > > --- gcc/gimple-ssa-sprintf.c.jj 2018-02-27 23:16:19.747948912 +0100 > > +++ gcc/gimple-ssa-sprintf.c2018-03-01 21:26:37.728861287 +0100 > > @@ -592,14 +592,12 @@ get_format_string (tree format, location > > /* The format

Re: [PATCH] i18n fixes in gimple-ssa-sprintf.c

2018-03-01 Thread Martin Sebor
On 03/01/2018 04:25 PM, Jakub Jelinek wrote: Hi! This patch fixes a couple of i18n bugs in gimple-ssa-sprintf.c. One issue was incorrect format attribute for format_warning_at_substring, which has ... and thus shouldn't use 0 for the last argument, but the first non-named argument position. An

[PATCH] i18n fixes in gimple-ssa-sprintf.c

2018-03-01 Thread Jakub Jelinek
Hi! This patch fixes a couple of i18n bugs in gimple-ssa-sprintf.c. One issue was incorrect format attribute for format_warning_at_substring, which has ... and thus shouldn't use 0 for the last argument, but the first non-named argument position. Another one is that a couple of fmtwarn calls nee