RE: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2025-01-28 Thread Bader, Lucas
Hi Dave, thanks for having a look. I'll rebase the change and resend it with the DCO sign-off. Best Lucas -Original Message- From: David Malcolm Sent: Tuesday, 28 January 2025 23:36 To: Bader, Lucas ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] get source line for diagnostic

Re: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2025-01-28 Thread David Malcolm
On Mon, 2019-12-16 at 11:18 +, Bader, Lucas wrote: > Hello, Hi Lucas. Thanks for the patch, and sorry for not seeing this patch before and thus the long delay in reviewing it. I started reviewing this and have various comments (mostly about introducing subroutines to simplify the logic), but

Re: Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2025-01-28 Thread Bader, Lucas
Thanks for having a look Jeff. Would be great to hear your thoughts on this patch David. Best Lucas > On 18. Jan 2025, at 17:41, Jeff Law wrote: > >  > >> On 1/3/25 7:27 AM, Bader, Lucas wrote: >> Hello and Happy New Year, >> as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open

Re: Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2025-01-18 Thread Jeff Law
On 1/3/25 7:27 AM, Bader, Lucas wrote: Hello and Happy New Year, as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open, I wanted to again bump this patch I provided a while back. It was earmarked for gcc-11 in https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539201.html

Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2025-01-03 Thread Bader, Lucas
diagnostic from preprocessed file / PR preprocessor/79106 Hello, within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source line and fixit hints

[PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2024-01-22 Thread Bader, Lucas
diagnostic from preprocessed file / PR preprocessor/79106 Hello, within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source line and fixit

Re: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2020-01-27 Thread Jeff Law
On Mon, 2019-12-16 at 11:18 +, Bader, Lucas wrote: > Hello, > > within a compile cluster, only the preprocessed output of GCC is transferred > to remote nodes for compilation. > When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. > prints out the affected source > l

[PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2020-01-02 Thread Bader, Lucas
Happy New Year and a ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01113.html -Original Message- From: Bader, Lucas Sent: Montag, 16. Dezember 2019 12:19 To: gcc-patches@gcc.gnu.org Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

[PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

2019-12-16 Thread Bader, Lucas
Hello, within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source line and fixit hints, it attempts to read the source file again, even