Re: [PATCH] gcov: make profile merging smarter

2021-10-13 Thread Martin Liška
On 10/11/21 16:05, Martin Liška wrote: May I install the patch now? Pushed to master, I guess we can tweak documentation in the future if needed. Martin

Re: [PATCH] gcov: make profile merging smarter

2021-10-11 Thread Martin Liška
PATCH] gcov: make profile merging smarter Support merging of profiles that are built from a different .o files but belong to the same source file. Moreover, a checksum is verified during profile merging and so we can safely combine such profile. PR gcov-profile/90364 gcc/ChangeLog: * cover

Re: [PATCH] gcov: make profile merging smarter

2021-10-11 Thread Martin Liška
On 10/5/21 12:04, Richard Biener wrote: On Mon, Oct 4, 2021 at 1:32 PM Martin Liška wrote: On 10/4/21 13:16, Richard Biener wrote: I meant in merge_one_data do not check ->stamp or ->checksum but instead rely on the counter merging code to detect mismatches (there's read_mismatch and read_err

Re: [PATCH] gcov: make profile merging smarter

2021-10-05 Thread Richard Biener via Gcc-patches
On Mon, Oct 4, 2021 at 1:32 PM Martin Liška wrote: > > On 10/4/21 13:16, Richard Biener wrote: > > I meant in merge_one_data do not check ->stamp or ->checksum but instead > > rely > > on the counter merging code to detect mismatches (there's read_mismatch and > > read_error). There's multiple t

Re: [PATCH] gcov: make profile merging smarter

2021-10-04 Thread Martin Liška
On 10/4/21 13:16, Richard Biener wrote: I meant in merge_one_data do not check ->stamp or ->checksum but instead rely on the counter merging code to detect mismatches (there's read_mismatch and read_error). There's multiple things we can do when we run into those: - when we did not actually m

Re: [PATCH] gcov: make profile merging smarter

2021-10-04 Thread Richard Biener via Gcc-patches
On Fri, Oct 1, 2021 at 12:53 PM Martin Liška wrote: > > On 10/1/21 12:17, Richard Biener wrote: > > On Fri, Oct 1, 2021 at 11:55 AM Martin Liška wrote: > >> > >> Support merging of profiles that are built from a different .o files > >> but belong to the same source file. Moreover, a checksum is v

Re: [PATCH] gcov: make profile merging smarter

2021-10-01 Thread Martin Liška
On 10/1/21 12:17, Richard Biener wrote: On Fri, Oct 1, 2021 at 11:55 AM Martin Liška wrote: Support merging of profiles that are built from a different .o files but belong to the same source file. Moreover, a checksum is verified during profile merging and so we can safely combine such profile

Re: [PATCH] gcov: make profile merging smarter

2021-10-01 Thread Richard Biener via Gcc-patches
On Fri, Oct 1, 2021 at 11:55 AM Martin Liška wrote: > > Support merging of profiles that are built from a different .o files > but belong to the same source file. Moreover, a checksum is verified > during profile merging and so we can safely combine such profile. > > Patch can bootstrap on x86_64-

[PATCH] gcov: make profile merging smarter

2021-10-01 Thread Martin Liška
Support merging of profiles that are built from a different .o files but belong to the same source file. Moreover, a checksum is verified during profile merging and so we can safely combine such profile. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'm going to install t