Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-25 Thread Arsen Arsenović via Gcc-patches
Richard Biener writes: > If it doesn't show any issues after a while on trunk it's OK for 13.2 I > think. Thanks, I'll re-propose it later then. Have a lovely day! -- Arsen Arsenović signature.asc Description: PGP signature

Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-24 Thread Richard Biener via Gcc-patches
On Fri, 21 Apr 2023, Arsen Arsenovi? wrote: > > Jakub Jelinek writes: > > > Doesn't fix any regression, so not ok for 13.1 and I wouldn't bother > > for 13.2 either. > > Okay, but it can affect --enable-languages=all in a slim edge case. > > Why not 13.2? It seems sufficiently simple. If it

Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-21 Thread Arsen Arsenović via Gcc-patches
Jakub Jelinek writes: > Doesn't fix any regression, so not ok for 13.1 and I wouldn't bother > for 13.2 either. Okay, but it can affect --enable-languages=all in a slim edge case. Why not 13.2? It seems sufficiently simple. Thanks, have a lovely night! -- Arsen Arsenović signature.asc Des

Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-21 Thread Jakub Jelinek via Gcc-patches
On Fri, Apr 21, 2023 at 08:27:22PM +0200, Arsen Arsenović wrote: > Hi Gaius, > > Gaius Mulley writes: > > > yes certainly this is fine. lgtm. Thanks for spotting and the patch > > Sure. Will push to master and wait for a RM to weigh in on 13. Doesn't fix any regression, so not ok for 13.1 a

Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-21 Thread Arsen Arsenović via Gcc-patches
Hi Gaius, Gaius Mulley writes: > yes certainly this is fine. lgtm. Thanks for spotting and the patch Sure. Will push to master and wait for a RM to weigh in on 13. Thanks! -- Arsen Arsenović signature.asc Description: PGP signature

Re: [PATCH] gcc/m2: Drop references to $(P)

2023-04-21 Thread Gaius Mulley via Gcc-patches
Arsen Arsenović writes: > $(P) seems to have been a workaround for some old, proprietary make > implementations that we no longer support. It was removed in > r0-31149-gb8dad04b688e9c. > > gcc/m2/ChangeLog: > > * Make-lang.in: Remove references to $(P). > * Make-maintainer.in: Ditto.

[PATCH] gcc/m2: Drop references to $(P)

2023-04-21 Thread Arsen Arsenović via Gcc-patches
$(P) seems to have been a workaround for some old, proprietary make implementations that we no longer support. It was removed in r0-31149-gb8dad04b688e9c. gcc/m2/ChangeLog: * Make-lang.in: Remove references to $(P). * Make-maintainer.in: Ditto. --- Hi, We spotted that the m2 mak