Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-09 Thread Thomas Koenig via Gcc-patches
Hi Bernhard, For Fortran identifiers, that would be really good. Would you do that? Is it really needed? We do not enter internal helper names (class names, anything artificial, anything leading underscore or leading uppercase) to the suggestions proposals so should never actually recommend a

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-08 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 9 Jun 2020 08:14:55 +0200 Thomas Koenig wrote: > Hi Tom, > > > Bernhard> Yes, this is probably OK although Fortran is case- > > Bernhard> insensitive. I think we lowercase names coming in from the > > Bernhard> source (at least for the internal identifier nodes), so we > > Bernhard> shou

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-08 Thread Thomas Koenig via Gcc-patches
Hi Tom, Bernhard> Yes, this is probably OK although Fortran is case- Bernhard> insensitive. I think we lowercase names coming in from the Bernhard> source (at least for the internal identifier nodes), so we Bernhard> should not be affected by any case change. I already checked it in, but FWIW i

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-08 Thread Tom Tromey
Bernhard> Yes, this is probably OK although Fortran is case- Bernhard> insensitive. I think we lowercase names coming in from the Bernhard> source (at least for the internal identifier nodes), so we Bernhard> should not be affected by any case change. I already checked it in, but FWIW it would be

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-08 Thread Bernhard Reutner-Fischer via Gcc-patches
On 5 June 2020 17:12:58 CEST, Thomas Koenig via Fortran wrote: >Hi Tom, > >> My earlier patch to add case handling to the spell checker caused a >> Fortran regression. I believe I must have misread the test results. >> >> This patch fixes the problem by changing the cutoff. I chose this >> val

Re: [PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-05 Thread Thomas Koenig via Gcc-patches
Hi Tom, My earlier patch to add case handling to the spell checker caused a Fortran regression. I believe I must have misread the test results. This patch fixes the problem by changing the cutoff. I chose this value because the previous patch effectively multiplied the result of get_edit_dist

[PATCH] fortran/95509 - fix spellcheck-operator.f90 regression

2020-06-05 Thread Tom Tromey
My earlier patch to add case handling to the spell checker caused a Fortran regression. I believe I must have misread the test results. This patch fixes the problem by changing the cutoff. I chose this value because the previous patch effectively multiplied the result of get_edit_distance by 2 (