Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-24 Thread Steve Kargl
On Mon, Dec 24, 2018 at 12:26:46PM +, Sudakshina Das wrote: > > > I am observing your new test pr88328.f90 failing on > arm-none-linux-gnueabihf: > Excess errors: > /build/src/gcc/gcc/testsuite/gfortran.dg/ieee/ieee_9.f90:20:36: Error: > Invalid kind for REAL at (1) > /build/src/gcc/gcc/tests

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-24 Thread Sudakshina Das
Hi Steve On 21/12/18 8:01 PM, Steve Kargl wrote: > On Fri, Dec 21, 2018 at 07:39:45PM +, Joseph Myers wrote: >> On Fri, 21 Dec 2018, Steve Kargl wrote: >> >>> scalbln(double x, long n) >>> { >>> >>> return (scalbn(x, (n > NMAX) ? NMAX : (n < NMIN) ? NMIN : (int)n)); >>> } >>> >>> A se

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Steve Kargl
On Fri, Dec 21, 2018 at 07:39:45PM +, Joseph Myers wrote: > On Fri, 21 Dec 2018, Steve Kargl wrote: > > > scalbln(double x, long n) > > { > > > > return (scalbn(x, (n > NMAX) ? NMAX : (n < NMIN) ? NMIN : (int)n)); > > } > > > > A search for glibc's libm locates https://tinyurl.com/yb

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Joseph Myers
On Fri, 21 Dec 2018, Steve Kargl wrote: > scalbln(double x, long n) > { > > return (scalbn(x, (n > NMAX) ? NMAX : (n < NMIN) ? NMIN : (int)n)); > } > > A search for glibc's libm locates https://tinyurl.com/ybcy8w4t > which is a bit-twiddling routine. Not sure it's worth the > effort. J

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Steve Kargl
On Fri, Dec 21, 2018 at 08:59:04PM +0200, Janne Blomqvist wrote: > On Fri, Dec 21, 2018 at 7:59 PM Steve Kargl < > > > > D.3853 = *i; > > __result_foo = scalbnq (c, > > (integer(kind=4)) MAX_EXPR , > > -2147483647>); > > > > The range [-32443,32443] is a subset of [-huge(),huge(0)]. > > > > Tr

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Janne Blomqvist
On Fri, Dec 21, 2018 at 7:59 PM Steve Kargl < s...@troutmask.apl.washington.edu> wrote: > On Fri, Dec 21, 2018 at 11:07:08AM +0200, Janne Blomqvist wrote: > > On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl < > > s...@troutmask.apl.washington.edu> wrote: > > > > > On Thu, Dec 20, 2018 at 01:47:39PM -0

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Steve Kargl
On Fri, Dec 21, 2018 at 06:31:27PM +0100, Thomas Koenig wrote: > Hi Steve, > > > No, I'm adding the missing functions to the INTERFACE. > > Ah, I see. What I missed was that the function is actually translated > to something else. > > So, OK for trunk, and thanks for the patch! > Janne, Thomas

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Steve Kargl
On Fri, Dec 21, 2018 at 11:07:08AM +0200, Janne Blomqvist wrote: > On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl < > s...@troutmask.apl.washington.edu> wrote: > > > On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote: > > > The attached patch has been tested on x86_64-*-freebsd. > > > > > >

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Thomas Koenig
Hi Steve, No, I'm adding the missing functions to the INTERFACE. Ah, I see. What I missed was that the function is actually translated to something else. So, OK for trunk, and thanks for the patch! Regards Thomas

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Steve Kargl
On Fri, Dec 21, 2018 at 11:07:08AM +0200, Janne Blomqvist wrote: > On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl < > s...@troutmask.apl.washington.edu> wrote: > > > On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote: > > > The attached patch has been tested on x86_64-*-freebsd. > > > > > >

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-21 Thread Janne Blomqvist
On Fri, Dec 21, 2018 at 8:22 AM Steve Kargl < s...@troutmask.apl.washington.edu> wrote: > On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote: > > The attached patch has been tested on x86_64-*-freebsd. > > > > OK to commit? > > > > 2018-12-20 Steven G. Kargl > > > > PR fortran/69

Re: [PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-20 Thread Steve Kargl
On Thu, Dec 20, 2018 at 01:47:39PM -0800, Steve Kargl wrote: > The attached patch has been tested on x86_64-*-freebsd. > > OK to commit? > > 2018-12-20 Steven G. Kargl > > PR fortran/69121 > * libgfortran/ieee/ieee_arithmetic.F90: Provide missing functions > in interface for

[PATCH] fortran/69121 -- Make IEEE_SCALB generic

2018-12-20 Thread Steve Kargl
The attached patch has been tested on x86_64-*-freebsd. It provides the missing pieces for IEEE_SCALB to allow it to be generic function. Briefly, when FX contributed IEEE_SCALB, he implemented a casting of the integer argument to the default integer kind. For integer(1) and integer(2), this is