Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-03 Thread Steve Kargl
On Sat, Oct 03, 2015 at 12:13:12PM +0200, Mikael Morin wrote: > > I have finally managed to find a patch that doesn't regress in the > testsuite. > > The gfc_add_in_common call in gfc_match_common is delayed after the > array spec handling and without return value check, so that errors are > ig

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-03 Thread Mikael Morin
Le 02/10/2015 18:44, Steve Kargl a écrit : On Fri, Oct 02, 2015 at 11:28:06AM +0200, Mikael Morin wrote: Le 01/10/2015 18:30, Steve Kargl a écrit : The call-stmt in the code is the start of an execution-construct A common-stmt is not allowed in an execution-construct. At least, that's how I in

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-02 Thread Steve Kargl
On Fri, Oct 02, 2015 at 11:28:06AM +0200, Mikael Morin wrote: > Le 01/10/2015 18:30, Steve Kargl a écrit : > > I'm fine with your patch, although I find the error message > > to be somewhat confusing as no procedure appears in COMMON. > > Well, XX is implicitly a procedure. > Yes, I understamf w

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-02 Thread Mikael Morin
Le 01/10/2015 18:30, Steve Kargl a écrit : I'm fine with your patch, although I find the error message to be somewhat confusing as no procedure appears in COMMON. Well, XX is implicitly a procedure. The call-stmt in the code is the start of an execution-construct. A common-stmt is not allowed

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-01 Thread Steve Kargl
On Thu, Oct 01, 2015 at 03:29:05PM +0200, Mikael Morin wrote: > Le 01/10/2015 14:16, Mikael Morin a écrit : > > Le 01/10/2015 02:07, Steve Kargl a écrit : > >> On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: > >>> Patch built and regression tested on x86_64-*-freebsd. > >>> OK to commi

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-01 Thread Mikael Morin
Le 01/10/2015 14:16, Mikael Morin a écrit : Le 01/10/2015 02:07, Steve Kargl a écrit : On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: Patch built and regression tested on x86_64-*-freebsd. OK to commit? The patch prevents the dereferencing of a NULL pointer by jumping out of the

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-10-01 Thread Mikael Morin
Le 01/10/2015 02:07, Steve Kargl a écrit : On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: Patch built and regression tested on x86_64-*-freebsd. OK to commit? The patch prevents the dereferencing of a NULL pointer by jumping out of the cleanup of a list of COMMON blocks. Hold on,

Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-09-30 Thread Steve Kargl
On Wed, Sep 30, 2015 at 05:06:30PM -0700, Steve Kargl wrote: > Patch built and regression tested on x86_64-*-freebsd. > OK to commit? > > The patch prevents the dereferencing of a NULL pointer > by jumping out of the cleanup of a list of COMMON blocks. > > 2015-09-30 Steven G. Kargl > >

[PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON

2015-09-30 Thread Steve Kargl
Patch built and regression tested on x86_64-*-freebsd. OK to commit? The patch prevents the dereferencing of a NULL pointer by jumping out of the cleanup of a list of COMMON blocks. 2015-09-30 Steven G. Kargl * symbol.c (gfc_restore_last_undo_checkpoint): Prevent ICE during cl