Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread FX
> Whoops, sorry about that. As you can see I have small patches > sitting in my tree. I tried to untangle the 'svn diff’ Thanks for cleaning and submitting those! I’ll try to review them over the next 2 days, if nobody beats me to it :) FX

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread Steve Kargl
On Fri, May 15, 2015 at 05:45:54PM +0200, FX wrote: > - You're missing the match.c part of the patch (I really had > a hard time figuring out how the patch was supposed to work! > then I read the one posted in the PR) Whoops, sorry about that. As you can see I have small patches sitting in my

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread FX
- You’re missing the match.c part of the patch (I really had a hard time figuring out how the patch was supposed to work! then I read the one posted in the PR) - Let’s avoid the strcmp() string comparison and use “op == INTRINSIC_NONE” as the condition (seems clearer and more efficient to me)

[PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? The patch allows gfortran to check a portion of C1202 that was previously mishandled. 2015-05-XX Steven G. Kargl PR fortran/66057 * interface.c(gfc_match_end_interface): Enfornce F2008 C1202 (R1201). 2015-05-XX Steven G. Kargl