Re: [PATCH] expr: Fix fallout from optimize store_expr from STRING_CST [PR95052]

2020-05-30 Thread Jeff Law via Gcc-patches
On Fri, 2020-05-29 at 22:03 +0200, Jakub Jelinek wrote: > On Fri, May 15, 2020 at 10:32:00AM -0600, Jeff Law via Gcc-patches wrote: > > > I wasn't sure if it wouldn't be safer to add some bool flag set to true by > > > the new code and then add gcc_assert in all the other paths, like > > > followi

[PATCH] expr: Fix fallout from optimize store_expr from STRING_CST [PR95052]

2020-05-29 Thread Jakub Jelinek via Gcc-patches
On Fri, May 15, 2020 at 10:32:00AM -0600, Jeff Law via Gcc-patches wrote: > > I wasn't sure if it wouldn't be safer to add some bool flag set to true by > > the new code and then add gcc_assert in all the other paths, like following > > incremental patch. I believe none of the asserts can trigger