Re: [PATCH] dwarf2out: Don't call expand_expr during early_dwarf [PR104407]

2022-02-08 Thread Jakub Jelinek via Gcc-patches
On Tue, Feb 08, 2022 at 02:20:28PM -0500, Jason Merrill wrote: > > > + return add_const_value_attribute (die, TYPE_MODE (type), rtl); > > > +} > > > + else > > > +{ > > > + /* For early_dwarf force mangling of all referenced symbols. */ > > > + tree initializer = init; > > > +

Re: [PATCH] dwarf2out: Don't call expand_expr during early_dwarf [PR104407]

2022-02-08 Thread Jason Merrill via Gcc-patches
On 2/8/22 03:35, Richard Biener wrote: On Tue, 8 Feb 2022, Jakub Jelinek wrote: Hi! As mentioned in the PR, since PR96690 r11-2834 we call rtl_for_decl_init which can call expand_expr already during early_dwarf. The comment and PR explains it that the intent is to ensure the referenced vars a

Re: [PATCH] dwarf2out: Don't call expand_expr during early_dwarf [PR104407]

2022-02-08 Thread Richard Biener via Gcc-patches
On Tue, 8 Feb 2022, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, since PR96690 r11-2834 we call rtl_for_decl_init > which can call expand_expr already during early_dwarf. The comment and PR > explains it that the intent is to ensure the referenced vars and functions > are properly mang

[PATCH] dwarf2out: Don't call expand_expr during early_dwarf [PR104407]

2022-02-08 Thread Jakub Jelinek via Gcc-patches
Hi! As mentioned in the PR, since PR96690 r11-2834 we call rtl_for_decl_init which can call expand_expr already during early_dwarf. The comment and PR explains it that the intent is to ensure the referenced vars and functions are properly mangled because free_lang_data doesn't cover everything, l