Re: [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-18 Thread Martin Sebor via Gcc-patches
On 3/12/20 2:10 PM, Jeff Law wrote: On Mon, 2020-03-09 at 14:33 -0600, Martin Sebor wrote: On 3/5/20 5:26 PM, Jeff Law wrote: On Fri, 2020-02-14 at 15:41 -0700, Martin Sebor wrote: Because attribute weakref introduces a kind of a definition, it can only be applied to declarations of symbols th

Re: [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-12 Thread Jeff Law via Gcc-patches
On Mon, 2020-03-09 at 14:33 -0600, Martin Sebor wrote: > On 3/5/20 5:26 PM, Jeff Law wrote: > > On Fri, 2020-02-14 at 15:41 -0700, Martin Sebor wrote: > > > Because attribute weakref introduces a kind of a definition, it can > > > only be applied to declarations of symbols that are not defined. GC

Re: [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-09 Thread Martin Sebor
On 3/5/20 5:26 PM, Jeff Law wrote: On Fri, 2020-02-14 at 15:41 -0700, Martin Sebor wrote: Because attribute weakref introduces a kind of a definition, it can only be applied to declarations of symbols that are not defined. GCC normally issues a warning when the attribute is applied to a defined

Re: [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-05 Thread Jeff Law
On Fri, 2020-02-14 at 15:41 -0700, Martin Sebor wrote: > Because attribute weakref introduces a kind of a definition, it can > only be applied to declarations of symbols that are not defined. GCC > normally issues a warning when the attribute is applied to a defined > symbol, but PR 92799 shows th

[PING #2][PATCH] drop weakref attribute on function definitions (PR 92799)

2020-03-02 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00883.html On 2/21/20 9:49 AM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00883.html On 2/14/20 3:41 PM, Martin Sebor wrote: Because attribute weakref introduces a kind of a definition, it can only be applied to d

PING [PATCH] drop weakref attribute on function definitions (PR 92799)

2020-02-21 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00883.html On 2/14/20 3:41 PM, Martin Sebor wrote: Because attribute weakref introduces a kind of a definition, it can only be applied to declarations of symbols that are not defined.  GCC normally issues a warning when the attribute is applied

[PATCH] drop weakref attribute on function definitions (PR 92799)

2020-02-14 Thread Martin Sebor
Because attribute weakref introduces a kind of a definition, it can only be applied to declarations of symbols that are not defined. GCC normally issues a warning when the attribute is applied to a defined symbol, but PR 92799 shows that it misses some cases on which it then leads to an ICE. The