Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-18 Thread Martin Sebor
On 01/15/2018 03:09 AM, Florian Weimer wrote: * Martin Sebor: +the virtual table. Modifying the representation of such objects may violate ^vtable pointer? The vtable itself is not corrupted, I assume. Well, what happens is undefined, so who knows? ;) But of course in reality, writ

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-17 Thread Jason Merrill
On Mon, Jan 15, 2018 at 5:09 AM, Florian Weimer wrote: > * Martin Sebor: > >> +the virtual table. Modifying the representation of such objects may violate >^vtable pointer? > > The vtable itself is not corrupted, I assume. Indeed. Jason

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-15 Thread Florian Weimer
* Martin Sebor: > +the virtual table. Modifying the representation of such objects may violate ^vtable pointer? The vtable itself is not corrupted, I assume.

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-14 Thread Martin Sebor
On 01/14/2018 03:31 AM, Jakub Jelinek wrote: On Sat, Jan 13, 2018 at 04:14:38PM -0700, Martin Sebor wrote: -The @option{-Wclass-memaccess} option is enabled by @option{-Wall}. +The @option{-Wclass-memaccess} option is enabled by @option{-Wall}. Casting Perhaps "Explicitly casting" instead? T

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-14 Thread Jakub Jelinek
On Sat, Jan 13, 2018 at 04:14:38PM -0700, Martin Sebor wrote: > -The @option{-Wclass-memaccess} option is enabled by @option{-Wall}. > +The @option{-Wclass-memaccess} option is enabled by @option{-Wall}. Casting Perhaps "Explicitly casting" instead? The implicit cast doesn't suppress it and occu

Re: [PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-13 Thread Jason Merrill
OK, thanks. On Sat, Jan 13, 2018 at 6:14 PM, Martin Sebor wrote: > Attached is the documentation update for Jakub's recent change > to recognize a cast to void* as a suppression mechanism for > -Wclass-memaccess (the last sentence). > > I also reworded the cumbersome first sentence a bit so the d

[PATCH] document -Wclass-memaccess suppression by casting (PR 81327)

2018-01-13 Thread Martin Sebor
Attached is the documentation update for Jakub's recent change to recognize a cast to void* as a suppression mechanism for -Wclass-memaccess (the last sentence). I also reworded the cumbersome first sentence a bit so the diff looks bigger than the substantive change itself actually is. Martin gc