Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2016-04-28 Thread Jeff Law
On 12/13/2015 01:19 AM, Markus Trippelsdorf wrote: Many developers are still using __attribute__((optimize())) in production code, although it quite broken. * doc/extend.texi (Common Function Attributes) [optimize]: Discourage use of the optimize attribute. I went back and review

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 05:40:57PM +0100, Markus Trippelsdorf wrote: > On 2015.12.14 at 11:20 -0500, Trevor Saunders wrote: > > On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > > > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > > > Markus Trippelsdorf writes: > > > > > >

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Manuel López-Ibáñez
On 14/12/15 16:40, Markus Trippelsdorf wrote: On 2015.12.14@11:20 -0500, Trevor Saunders wrote: On Mon, Dec 14, 2015@10:01:27AM +0100, Richard Biener wrote: On Sun, Dec 13, 2015@9:03 PM, Andi Kleen wrote: Markus Trippelsdorf writes: Many developers are still using __attribute__((optimize()

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Markus Trippelsdorf
On 2015.12.14 at 11:20 -0500, Trevor Saunders wrote: > On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > > Markus Trippelsdorf writes: > > > > > >> Many developers are still using __attribute__((optimize())) in > > >> produc

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > Markus Trippelsdorf writes: > > > >> Many developers are still using __attribute__((optimize())) in > >> production code, although it quite broken. > > > > Wo reads documentati

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Richard Biener
On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > Markus Trippelsdorf writes: > >> Many developers are still using __attribute__((optimize())) in >> production code, although it quite broken. > > Wo reads documentation? @) If you want to discourage it better warn once > at runtime. We're also

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-13 Thread Andi Kleen
Markus Trippelsdorf writes: > Many developers are still using __attribute__((optimize())) in > production code, although it quite broken. Wo reads documentation? @) If you want to discourage it better warn once at runtime. -Andi

[PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-13 Thread Markus Trippelsdorf
Many developers are still using __attribute__((optimize())) in production code, although it quite broken. * doc/extend.texi (Common Function Attributes) [optimize]: Discourage use of the optimize attribute. diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 883d9b334ab5