Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-15 Thread Richard Sandiford via Gcc-patches
Jakub Jelinek writes: > On Thu, Feb 11, 2021 at 03:03:38PM +, Richard Sandiford via Gcc-patches > wrote: >> gcc/ >> * df-problems.c (df_lr_bb_local_compute): Treat partial definitions >> as read-modify operations. >> >> gcc/testsuite/ >> * gcc.dg/rtl/aarch64/multi-subreg-1.c:

Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-12 Thread Jakub Jelinek via Gcc-patches
On Thu, Feb 11, 2021 at 03:03:38PM +, Richard Sandiford via Gcc-patches wrote: > gcc/ > * df-problems.c (df_lr_bb_local_compute): Treat partial definitions > as read-modify operations. > > gcc/testsuite/ > * gcc.dg/rtl/aarch64/multi-subreg-1.c: New test. The test fails ever

Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-12 Thread Richard Biener via Gcc-patches
On Fri, Feb 12, 2021 at 10:59 AM Richard Sandiford wrote: > > Richard Biener writes: > > On Thu, Feb 11, 2021 at 4:33 PM Richard Sandiford via Gcc-patches > > wrote: > >> > >> df_lr_bb_local_compute has: > >> > >> FOR_EACH_INSN_INFO_DEF (def, insn_info) > >> /* If the def is to onl

Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-12 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Thu, Feb 11, 2021 at 4:33 PM Richard Sandiford via Gcc-patches > wrote: >> >> df_lr_bb_local_compute has: >> >> FOR_EACH_INSN_INFO_DEF (def, insn_info) >> /* If the def is to only part of the reg, it does >>not kill the other defs that reach h

Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-12 Thread Richard Biener via Gcc-patches
On Thu, Feb 11, 2021 at 4:33 PM Richard Sandiford via Gcc-patches wrote: > > df_lr_bb_local_compute has: > > FOR_EACH_INSN_INFO_DEF (def, insn_info) > /* If the def is to only part of the reg, it does >not kill the other defs that reach here. */ > if (!(DF_REF_FL

[PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-11 Thread Richard Sandiford via Gcc-patches
df_lr_bb_local_compute has: FOR_EACH_INSN_INFO_DEF (def, insn_info) /* If the def is to only part of the reg, it does not kill the other defs that reach here. */ if (!(DF_REF_FLAGS (def) & (DF_REF_PARTIAL | DF_REF_CONDITIONAL))) However, as noted in the comment i