Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-31 Thread Richard Biener
On July 31, 2020 8:44:49 PM GMT+02:00, David Edelsohn wrote: >On Thu, Jul 30, 2020 at 11:55:19AM +0200, Richard Biener wrote: > >> Bootstrap and regtest running on x86_64-unknown-linux-gnu. >> >> OK for trunk and backports? > >I'd go with it for trunk and 10.2.1 now and consider further backports

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-31 Thread David Edelsohn via Gcc-patches
On Thu, Jul 30, 2020 at 11:55:19AM +0200, Richard Biener wrote: > Bootstrap and regtest running on x86_64-unknown-linux-gnu. > > OK for trunk and backports? I'd go with it for trunk and 10.2.1 now and consider further backports later. Maybe even defer the 10.2.1 backport for two weeks. I believ

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-31 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 31, 2020 at 02:24:08PM +0200, Richard Biener wrote: > 2020-07-30 Richard Biener > > PR debug/96383 > c-family/ > * c-common.h (c_common_finalize_early_debug): Declare. > * c-common.c: Include debug.h. > (c_common_finalize_early_debug): finalize_early_de

[PATCH] debug/96383 - emit debug info for used external functions

2020-07-31 Thread Richard Biener
This makes sure to emit full declaration DIEs including formal parameters for used external functions. This helps debugging when debug information of the external entity is not available and also helps external tools cross-checking ABI compatibility which was the bug reporters use case. For cc1 t

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-30 Thread Richard Biener
On Thu, 30 Jul 2020, Jakub Jelinek wrote: > On Thu, Jul 30, 2020 at 11:55:19AM +0200, Richard Biener wrote: > > For cc1 this affects debug information size as follows: > > > > VM SIZE FILE SIZE > > ++ GROWING ++ > > [ = ] 0 .debug_in

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-30 Thread Richard Biener
On Thu, 30 Jul 2020, Andreas Schwab wrote: > On Jul 30 2020, Richard Biener wrote: > > > diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/pr96383-1.c > > b/gcc/testsuite/gcc.dg/debug/dwarf2/pr96383-1.c > > new file mode 100644 > > index 000..ede30f9a95e > > --- /dev/null > > +++ b/gcc/test

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-30 Thread Andreas Schwab
On Jul 30 2020, Richard Biener wrote: > diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/pr96383-1.c > b/gcc/testsuite/gcc.dg/debug/dwarf2/pr96383-1.c > new file mode 100644 > index 000..ede30f9a95e > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/pr96383-1.c > @@ -0,0 +1,17 @@ > +

Re: [PATCH] debug/96383 - emit debug info for used external functions

2020-07-30 Thread Jakub Jelinek via Gcc-patches
On Thu, Jul 30, 2020 at 11:55:19AM +0200, Richard Biener wrote: > For cc1 this affects debug information size as follows: > > VM SIZE FILE SIZE > ++ GROWING ++ > [ = ] 0 .debug_info +1.63Mi +1.3% > [ = ] 0 .debug_str +2

[PATCH] debug/96383 - emit debug info for used external functions

2020-07-30 Thread Richard Biener
This makes sure to emit full declaration DIEs including formal parameters for used external functions. This helps debugging when debug information of the external entity is not available and also helps external tools cross-checking ABI compatibility which was the bug reporters use case. For cc1 t