Re: [PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Jakub Jelinek
On Mon, Jan 13, 2025 at 07:29:52PM +0100, Iain Buclaw wrote: > For example, changing the common package sources we end up with the > following, though can't say I'm a strong fan of having test and > optionally mkdir ran on every recipe execution. You also then need to handle it for cleaning etc.

Re: [PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Iain Buclaw
Excerpts from Jakub Jelinek's message of Januar 13, 2025 2:58 pm: > On Mon, Jan 13, 2025 at 02:45:28PM +0100, Arsen Arsenović wrote: >> > So the former d/.deps/file.Po which handled both d/dmd/common/file.d and >> > d/dmd/root/file.d in your case would be d/.deps/d-common-file.o.d and >> > d/.deps/

Re: [PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Jakub Jelinek
On Mon, Jan 13, 2025 at 02:45:28PM +0100, Arsen Arsenović wrote: > > So the former d/.deps/file.Po which handled both d/dmd/common/file.d and > > d/dmd/root/file.d in your case would be d/.deps/d-common-file.o.d and > > d/.deps/d-root-file.o.d while with the above DEPFILE it would be > > d/.deps/co

Re: [PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Arsen Arsenović
Jakub Jelinek writes: > On Sun, Jan 12, 2025 at 04:16:58PM +0100, Arsen Arsenović wrote: >> Regstrapped on x86_64-pc-linux-gnu. I've also checked the generated >> dependency files are correct by hand and "instrumented" the build to >> fail if two dependency files are the same, by doing the follo

Re: [PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Jakub Jelinek
On Mon, Jan 13, 2025 at 11:00:09AM +0100, Jakub Jelinek wrote: > Why do you need there the directory or suffix? > $(*F) is clearly bad, because there are rules like > d/%.o: d/dmd/%.d > $(DCOMPILE) $(D_INCLUDES) $< > $(DPOSTCOMPILE) > > d/common-%.o: d/dmd/common/%.d >

[PATCH] d, v2: give dependency files better filenames

2025-01-13 Thread Jakub Jelinek
On Sun, Jan 12, 2025 at 04:16:58PM +0100, Arsen Arsenović wrote: > Regstrapped on x86_64-pc-linux-gnu. I've also checked the generated > dependency files are correct by hand and "instrumented" the build to > fail if two dependency files are the same, by doing the following: > > DPOSTCOMPILE = !