Re: [PATCH] coroutines: Add a cleanup expression for g-r-o when needed [PR95477].

2020-06-23 Thread Nathan Sidwell
On 6/12/20 4:06 PM, Iain Sandoe wrote: Iain Sandoe wrote: Nathan Sidwell wrote: On 6/8/20 5:17 AM, Iain Sandoe wrote: + r = gro_is_void_p ? integer_zero_node : rvalue (gro); + /* The return object is constructed, even if the gro is void. */ Would error_mark_node work here?

Re: [PATCH] coroutines: Add a cleanup expression for g-r-o when needed [PR95477].

2020-06-12 Thread Iain Sandoe
Iain Sandoe wrote: > Nathan Sidwell wrote: > >> On 6/8/20 5:17 AM, Iain Sandoe wrote: >>> + r = gro_is_void_p ? integer_zero_node : rvalue (gro); >>> + /* The return object is constructed, even if the gro is void. */ >> >> Would error_mark_node work here? I presume we've already d

Re: [PATCH] coroutines: Add a cleanup expression for g-r-o when needed [PR95477].

2020-06-08 Thread Iain Sandoe
Nathan Sidwell wrote: On 6/8/20 5:17 AM, Iain Sandoe wrote: Hi The PR reports that we fail to destroy the object initially created from the get-return-object call. Fixed by adding a cleanup when the DTOR is non-trivial. In addition, to meet the specific wording that the call to get_return_o

Re: [PATCH] coroutines: Add a cleanup expression for g-r-o when needed [PR95477].

2020-06-08 Thread Nathan Sidwell
On 6/8/20 5:17 AM, Iain Sandoe wrote: Hi The PR reports that we fail to destroy the object initially created from the get-return-object call. Fixed by adding a cleanup when the DTOR is non-trivial. In addition, to meet the specific wording that the call to get_return_object creates the glvalu

[PATCH] coroutines: Add a cleanup expression for g-r-o when needed [PR95477].

2020-06-08 Thread Iain Sandoe
Hi The PR reports that we fail to destroy the object initially created from the get-return-object call. Fixed by adding a cleanup when the DTOR is non-trivial. In addition, to meet the specific wording that the call to get_return_object creates the glvalue for the return, we must construct that