Re: [PATCH] core: Support heap-based trampolines

2023-09-16 Thread Iain Sandoe
Hi Richard, > On 14 Sep 2023, at 11:18, Richard Biener wrote: > > On Wed, Sep 6, 2023 at 5:44 PM FX Coudert wrote: >> >> ping**2 on the revised patch, for Richard or another global reviewer. So far >> all review feedback is that it’s a step forward, and it’s been widely used >> for both aar

Re: [PATCH] core: Support heap-based trampolines

2023-09-14 Thread Richard Biener via Gcc-patches
On Wed, Sep 6, 2023 at 5:44 PM FX Coudert wrote: > > Hi, > > ping**2 on the revised patch, for Richard or another global reviewer. So far > all review feedback is that it’s a step forward, and it’s been widely used > for both aarch64-darwin and x86_64-darwin distributions for almost three > yea

Re: [PATCH] core: Support heap-based trampolines

2023-09-06 Thread FX Coudert via Gcc-patches
Hi, ping**2 on the revised patch, for Richard or another global reviewer. So far all review feedback is that it’s a step forward, and it’s been widely used for both aarch64-darwin and x86_64-darwin distributions for almost three years now. OK to commit? FX > Le 5 août 2023 à 16:20, FX Couder

Re: [PATCH] core: Support heap-based trampolines

2023-08-20 Thread FX Coudert via Gcc-patches
Hi, A gentle ping on the revised patch, for Richard or another global reviewer. Thanks, FX > Le 5 août 2023 à 16:20, FX Coudert a écrit : > > Hi Richard, > > Thanks for your feedback. Here is an amended version of the patch, taking > into consideration your requests and the following discu

Re: [PATCH] core: Support heap-based trampolines

2023-08-05 Thread FX Coudert via Gcc-patches
Hi Richard, Thanks for your feedback. Here is an amended version of the patch, taking into consideration your requests and the following discussion. There is no configure option for the libgcc part, and the documentation is amended. The patch is split into three commits for core, target and lib

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Martin Uecker via Gcc-patches
Am Mittwoch, dem 19.07.2023 um 15:23 +0100 schrieb Iain Sandoe: > Hi Martin, > > > On 19 Jul 2023, at 11:43, Martin Uecker via Gcc-patches > > wrote: > > > > Am Mittwoch, dem 19.07.2023 um 10:29 +0100 schrieb Iain Sandoe: > > > > > On 19 Jul 2023, at 10:04, Martin Uecker > > > > wrote: > > >

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 11:43, Martin Uecker via Gcc-patches > wrote: > > Am Mittwoch, dem 19.07.2023 um 10:29 +0100 schrieb Iain Sandoe: >>> On 19 Jul 2023, at 10:04, Martin Uecker >>> wrote: >> > On 17 Jul 2023, >>> >> You mention setjmp/longjmp - on darwin and othe

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Martin Uecker via Gcc-patches
Am Mittwoch, dem 19.07.2023 um 10:29 +0100 schrieb Iain Sandoe: > Hi Martin, > > > On 19 Jul 2023, at 10:04, Martin Uecker > > wrote: > > > > > On 17 Jul 2023, > > > > > > > > > > You mention setjmp/longjmp - on darwin and other platforms > > > requiring > > > > > non-stack based trampolines

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 10:04, Martin Uecker wrote: >>> On 17 Jul 2023, >> > You mention setjmp/longjmp - on darwin and other platforms >> requiring non-stack based trampolines does the system runtime provide means to deal with this issue like >> an alternate alloc

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Martin Uecker via Gcc-patches
> > > On 17 Jul 2023, > > >> You mention setjmp/longjmp - on darwin and other platforms > requiring > >> non-stack based trampolines > >> does the system runtime provide means to deal with this issue like > an > >> alternate allocation method > >> or a way to register cleanup? > > > > There

Re: [PATCH] core: Support heap-based trampolines

2023-07-17 Thread Iain Sandoe
> On 17 Jul 2023, at 07:58, Iain Sandoe wrote > >> On 17 Jul 2023, at 07:43, FX Coudert wrote: >> >> >> There is an alternate mechanism relying on system libraries that is possible >> on darwin specifically (I don’t know for other targets) but it will only >> work for signed binaries, an

Re: [PATCH] core: Support heap-based trampolines

2023-07-16 Thread Iain Sandoe
> On 17 Jul 2023, at 07:43, FX Coudert wrote: > > Hi, > >> Since this affects the ABI of libgcc I think we don't want that part >> to be user configurable but rather determined by >> some static list of targets that opt-in to this config. > > If I do that, do the Linux maintainers want Linux

Re: [PATCH] core: Support heap-based trampolines

2023-07-16 Thread FX Coudert via Gcc-patches
Hi, > Since this affects the ABI of libgcc I think we don't want that part > to be user configurable but rather determined by > some static list of targets that opt-in to this config. If I do that, do the Linux maintainers want Linux in or out? > You mention setjmp/longjmp - on darwin and other

Re: [PATCH] core: Support heap-based trampolines

2023-07-16 Thread Richard Biener via Gcc-patches
On Sun, Jul 16, 2023 at 12:39 PM FX Coudert via Gcc-patches wrote: > > Hi, > > This is a reworked version (following review) of the patch by Maxim Blinov > and Iain Sandoe enabling heap-based trampolines. What has changed since the > last version: > > - wording changes, preferring to use “heap-b

[PATCH] core: Support heap-based trampolines

2023-07-16 Thread FX Coudert via Gcc-patches
Hi, This is a reworked version (following review) of the patch by Maxim Blinov and Iain Sandoe enabling heap-based trampolines. What has changed since the last version: - wording changes, preferring to use “heap-based trampolines” rather than “off-stack trampolines” - the option triggering gen