Re: [PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-09 Thread Joseph Myers
On Fri, 6 Dec 2024, Thomas Schwinge wrote: > First: Tom, what was your original intention why we'd keep the generated > files in the sources? (..., instead of just generating them at build > time, like 'gcc/config/nvptx/t-omp-device' does for > 'omp-device-properties-nvptx', for example. In that

Re: [PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-06 Thread Sam James
Thomas Schwinge writes: > Hi Sam and Tom! Hi! > > On 2024-12-06T09:13:40+, Sam James wrote: >> Providing parameters to `.` when sourcing is a bashism and not supported >> by POSIX shell which causes a build failure when compiling a toolchain >> for nvptx-none with dash as /bin/sh. > > Hmm,

Re: [PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-06 Thread Thomas Schwinge
Hi Sam and Tom! On 2024-12-06T09:13:40+, Sam James wrote: > Providing parameters to `.` when sourcing is a bashism and not supported > by POSIX shell which causes a build failure when compiling a toolchain > for nvptx-none with dash as /bin/sh. Hmm, something must be wrong in that statement,

[PATCH] config: nvptx: fix bashisms with gen-copyright.sh use

2024-12-06 Thread Sam James
Providing parameters to `.` when sourcing is a bashism and not supported by POSIX shell which causes a build failure when compiling a toolchain for nvptx-none with dash as /bin/sh. gen-copyright.sh takes a parameter for the format of copyright notice required. Switch that to using an environment v