Re: [PATCH] combine lhs zero_extract fix (PR78186)

2016-11-07 Thread Segher Boessenkool
On Mon, Nov 07, 2016 at 02:00:46PM +0100, Christophe Lyon wrote: > > Confirmed. What a nasty, nasty bug, and it has been here for decades > > it seems. Could you please open a PR? > > > Sure, I've created PR78232 for this. Thanks! I have a patch btw, it's regstrapping. Not sure it is fully cor

Re: [PATCH] combine lhs zero_extract fix (PR78186)

2016-11-07 Thread Christophe Lyon
On 7 November 2016 at 10:14, Segher Boessenkool wrote: > Hi Christophe, > > On Fri, Nov 04, 2016 at 02:31:28PM +0100, Christophe Lyon wrote: >> Since this commit I have noticed execution failures on "old" arm targets: >> >> gcc.dg/torture/pr48124-4.c -O1 execution test >> gcc.dg/torture/pr4

Re: [PATCH] combine lhs zero_extract fix (PR78186)

2016-11-07 Thread Segher Boessenkool
Hi Christophe, On Fri, Nov 04, 2016 at 02:31:28PM +0100, Christophe Lyon wrote: > Since this commit I have noticed execution failures on "old" arm targets: > > gcc.dg/torture/pr48124-4.c -O1 execution test > gcc.dg/torture/pr48124-4.c -O2 execution test > gcc.dg/torture/pr48124-4.c

Re: [PATCH] combine lhs zero_extract fix (PR78186)

2016-11-04 Thread Christophe Lyon
On 3 November 2016 at 17:01, Segher Boessenkool wrote: > I managed to forget to mask the thing inserted. Tested on powerpc64-linux > {-m32,-m64}, and Bin tested on arm. Applying to trunk. > > > Segher > > > 2016-11-03 Segher Boessenkool > > PR rtl-optimization/78186 > * combin

[PATCH] combine lhs zero_extract fix (PR78186)

2016-11-03 Thread Segher Boessenkool
I managed to forget to mask the thing inserted. Tested on powerpc64-linux {-m32,-m64}, and Bin tested on arm. Applying to trunk. Segher 2016-11-03 Segher Boessenkool PR rtl-optimization/78186 * combine.c (change_zero_ext): Mask the RHS of a zero_extract as well, wh