Re: [PATCH] combine: Fix up -fcompare-debug issue in the combiner [PR104544]

2022-02-16 Thread Segher Boessenkool
On Wed, Feb 16, 2022 at 11:55:23AM +0100, Jakub Jelinek wrote: > On Wed, Feb 16, 2022 at 04:44:58AM -0600, Segher Boessenkool wrote: > > About half of the similar loops in combine.c are still broken this way, > > from a quick sampling :-( > > Looking for just NONDEBUG_INSN_P, I don't see any other

Re: [PATCH] combine: Fix up -fcompare-debug issue in the combiner [PR104544]

2022-02-16 Thread Jakub Jelinek via Gcc-patches
On Wed, Feb 16, 2022 at 04:44:58AM -0600, Segher Boessenkool wrote: > > --- gcc/combine.cc.jj 2022-02-11 13:51:56.294928090 +0100 > > +++ gcc/combine.cc 2022-02-15 14:15:41.663012950 +0100 > > @@ -4223,10 +4223,12 @@ try_combine (rtx_insn *i3, rtx_insn *i2, > > for (rtx_insn *insn = NE

Re: [PATCH] combine: Fix up -fcompare-debug issue in the combiner [PR104544]

2022-02-16 Thread Segher Boessenkool
Hi! On Wed, Feb 16, 2022 at 09:53:34AM +0100, Jakub Jelinek wrote: > On the following testcase on aarch64-linux, we behave differently > with -g and -g0. [ huge snip ] > The following patch fixes that by instead ignoring debug insns during the > searching. We can still check BLOCK_FOR_INSN (ins

[PATCH] combine: Fix up -fcompare-debug issue in the combiner [PR104544]

2022-02-16 Thread Jakub Jelinek via Gcc-patches
Hi! On the following testcase on aarch64-linux, we behave differently with -g and -g0. The problem is that on: (insn 10011 10010 10012 2 (set (reg:CC 66 cc) (compare:CC (reg:DI 105) (const_int 0 [0]))) "pr104544.c":18:3 407 {cmpdi} (expr_list:REG_DEAD (reg:DI 105)