Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-10-01 Thread Jeff Law
On 10/01/14 16:36, Segher Boessenkool wrote: On Sat, Sep 27, 2014 at 05:03:26PM -0500, Segher Boessenkool wrote: I've tried to make a stable future-proof testcase that does such a three-insn combination. Not easy at all. Turns out it is quite easy (when you've seen the solution, anyway :-P )

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-10-01 Thread Segher Boessenkool
On Sat, Sep 27, 2014 at 05:03:26PM -0500, Segher Boessenkool wrote: > I've tried to make a stable future-proof testcase that does such a three-insn > combination. Not easy at all. Turns out it is quite easy (when you've seen the solution, anyway :-P ) Tested on powerpc64-linux as before, and boo

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-29 Thread Jeff Law
On 09/27/14 16:03, Segher Boessenkool wrote: On Mon, Sep 22, 2014 at 04:20:12PM -0600, Jeff Law wrote: Can you add a testcase which shows the 3-insn combination from PR62151 applying? I've tried to make a stable future-proof testcase that does such a three-insn combination. Not easy at all.

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-27 Thread Segher Boessenkool
On Mon, Sep 22, 2014 at 04:20:12PM -0600, Jeff Law wrote: > Can you add a testcase which shows the 3-insn combination from PR62151 > applying? I've tried to make a stable future-proof testcase that does such a three-insn combination. Not easy at all. But now it dawns on me: do you just want the

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-22 Thread Bin.Cheng
On Fri, Sep 12, 2014 at 4:01 AM, Jeff Law wrote: > On 09/11/14 13:01, Segher Boessenkool wrote: >> >> Ping? > > Not forgotten. Still waiting to hear back from Bin on my recommendation > that we drop the bogus note on the floor and avoid combining pseudos with > multiple sets like that. Sorry tha

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-22 Thread Jeff Law
On 09/03/14 07:51, Segher Boessenkool wrote: This came up when investigating PR62151. In that PR combine messes up a four-insn combination. It should really have done the combination of the first three insns in that. The second of those instructions sets a register; the third clobbers the same

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-11 Thread Jeff Law
On 09/11/14 13:01, Segher Boessenkool wrote: Ping? Not forgotten. Still waiting to hear back from Bin on my recommendation that we drop the bogus note on the floor and avoid combining pseudos with multiple sets like that. Jeff

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-09-11 Thread Segher Boessenkool
Ping? On Wed, Sep 03, 2014 at 06:51:44AM -0700, Segher Boessenkool wrote: > This came up when investigating PR62151. In that PR combine messes up a > four-insn combination. It should really have done the combination of the > first three insns in that. The second of those instructions sets a reg

[PATCH] combine: Allow substituting the target reg of a clobber

2014-09-03 Thread Segher Boessenkool
This came up when investigating PR62151. In that PR combine messes up a four-insn combination. It should really have done the combination of the first three insns in that. The second of those instructions sets a register; the third clobbers the same. Substituting the source of the set into the