Re: [PATCH] combine: Add REG_DEAD notes to the last instruction after a split [PR118914]

2025-03-19 Thread Jeff Law
On 3/16/25 11:20 AM, Andrew Pinski wrote: gcc/ChangeLog: PR rtl-optimization/118914 * combine.cc (recog_for_combine): Add old_nregs and new_nregs argument (defaulting to 0). Update call to recog_for_combine_1. (combine_split_insns): Add old_nregs and new_nregs arg

Re: [PATCH] combine: Add REG_DEAD notes to the last instruction after a split [PR118914]

2025-03-16 Thread Andrew Pinski
On Sun, Mar 16, 2025 at 10:10 AM Jeff Law wrote: > > > > On 2/19/25 9:13 PM, Andrew Pinski wrote: > > So gcc.target/aarch64/rev16_2.c started to fail after > > r15-268-g9dbff9c05520a7, > > the problem is combine now rejects the instruction combine. This happens > > because > > after a different

Re: [PATCH] combine: Add REG_DEAD notes to the last instruction after a split [PR118914]

2025-03-16 Thread Jeff Law
On 2/19/25 9:13 PM, Andrew Pinski wrote: So gcc.target/aarch64/rev16_2.c started to fail after r15-268-g9dbff9c05520a7, the problem is combine now rejects the instruction combine. This happens because after a different combine which uses a define_split and that define_split creates a new pseu

RE: [PATCH] combine: Add REG_DEAD notes to the last instruction after a split [PR118914]

2025-03-10 Thread Andrew Pinski (QUIC)
> -Original Message- > From: Andrew Pinski (QUIC) > Sent: Wednesday, February 19, 2025 8:14 PM > To: gcc-patches@gcc.gnu.org > Cc: Andrew Pinski (QUIC) > Subject: [PATCH] combine: Add REG_DEAD notes to the last > instruction after a split [PR118914] > > So g

[PATCH] combine: Add REG_DEAD notes to the last instruction after a split [PR118914]

2025-02-19 Thread Andrew Pinski
So gcc.target/aarch64/rev16_2.c started to fail after r15-268-g9dbff9c05520a7, the problem is combine now rejects the instruction combine. This happens because after a different combine which uses a define_split and that define_split creates a new pseudo register. That new pseudo register is dead