> On 22 Mar 2025, at 23:13, Robert Dubner wrote:
> But, by all means, if you have a fix for something I am not seeing, a fix
> that doesn't mess with the status quo ante, then by all means, apply it.
I applied the simplest fix possible - which was to remove the trailling //
from the conversion
ly it.
I regret any confusion.
Bob D.
> -Original Message-
> From: Iain Sandoe
> Sent: Saturday, March 22, 2025 04:29
> To: Robert Dubner
> Cc: GCC Patches
> Subject: Re: [PATCH] cobol: Address some iconv issues.
>
> Hello Robert.
>
> I fear we might b
Hello Robert.
I fear we might be at cross-purposes here ...
> On 22 Mar 2025, at 02:34, Robert Dubner wrote:
>
> I can't comment on what happens on Apple systems. I've never tried it.
>
> I chose CP1252 because it seemed to have the greatest coverage for much of
> western Europe. It also has
> Secondly, using Windows code page 1252 as a default seems overly
restrictive.
>-static const char standard_internal[] = "CP1252//";
>+static const char standard_internal[] =
>+#if __APPLE__
>+"ISO8859-1";
>+#else
>+"CP1252//";
>+#endif
I'd highly suggest to go with ISO8859-15 in general (=drop
; Subject: Re: [PATCH] cobol: Address some iconv issues.
>
>
>
> > On 21 Mar 2025, at 22:11, Robert Dubner wrote:
> >
>
> > So, please, stick with the default 1252 for existing code -- as you
> noted,
> > changing the page breaks some tests.
>
>
> On 21 Mar 2025, at 22:11, Robert Dubner wrote:
>
> So, please, stick with the default 1252 for existing code -- as you noted,
> changing the page breaks some tests.
So … like so?
#if __APPLE__
“CP1252"
#else
"CP1252//"
#endif
(I’m not sure what the trailing ‘//‘ does on Linux [it’s an
t; From: Iain Sandoe
> Sent: Friday, March 21, 2025 06:06
> To: rdub...@symas.com; gcc-patches@gcc.gnu.org
> Subject: [PATCH] cobol: Address some iconv issues.
>
> Darwin/macOS installed libiconv does not accept // trailers on
> conversion codes; (it does accept // with TRANSLIT
Darwin/macOS installed libiconv does not accept // trailers on
conversion codes; (it does accept // with TRANSLIT etc after it)
Anyway the current setting causes the init_iconv to fail - and
then that SEGVs later. So let's at least print a warning if we
fail to init the conversion.
Secondly, usin
