Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-30 Thread Richard Biener
On Wed, Nov 28, 2018 at 7:18 PM Martin Sebor wrote: > > On 11/28/18 6:35 AM, Richard Biener wrote: > > On Tue, Nov 27, 2018 at 3:52 AM Martin Sebor wrote: > >> > >> Ping: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01759.html > >> > >> If there are no objections or suggestions for tweaks I'll c

Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-28 Thread Martin Sebor
On 11/28/18 6:35 AM, Richard Biener wrote: On Tue, Nov 27, 2018 at 3:52 AM Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01759.html If there are no objections or suggestions for tweaks I'll commit this updated comment this week. Please do not commit such changes w/

Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-28 Thread Richard Biener
On Tue, Nov 27, 2018 at 3:52 AM Martin Sebor wrote: > > Ping: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01759.html > > If there are no objections or suggestions for tweaks I'll commit > this updated comment this week. Please do not commit such changes w/o approval. Does the new comments matc

Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-26 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01759.html If there are no objections or suggestions for tweaks I'll commit this updated comment this week. On 11/20/18 1:24 PM, Martin Sebor wrote: On 11/20/2018 11:02 AM, Martin Sebor wrote: Would the updated comments in the attached patch

Re: [PATCH] clarify comments for implicit_p flag for built-ins

2018-11-20 Thread Martin Sebor
On 11/20/2018 11:02 AM, Martin Sebor wrote: Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the f

[PATCH] clarify comments for implicit_p flag for built-ins

2018-11-20 Thread Martin Sebor
Would the updated comments in the attached patch more accurately describe the purpose of the IMPLICIT_P flag and the builtin_decl_explicit() and builtin_decl_implicit() functions? I ended up here while trying to understand the differences between the functions on different targets and decide whic