Re: [PATCH] check_format fixes

2019-06-12 Thread Steve Kargl
On Wed, Jun 12, 2019 at 09:24:39AM +0200, Jakub Jelinek wrote: > On Tue, Jun 11, 2019 at 12:49:32PM +0200, Jakub Jelinek wrote: > > Tested on x86_64-linux with check-gfortran, ok for trunk if full > > bootstrap/regtest > > passes? > > > > 2019-06-11 Jakub Jelinek > > > > * io.c (check_for

Re: [PATCH] check_format fixes

2019-06-12 Thread Jakub Jelinek
On Tue, Jun 11, 2019 at 12:49:32PM +0200, Jakub Jelinek wrote: > Tested on x86_64-linux with check-gfortran, ok for trunk if full > bootstrap/regtest > passes? > > 2019-06-11 Jakub Jelinek > > * io.c (check_format): Use G_(...) instead of _(...) for error values, > append " in for

[PATCH] check_format fixes

2019-06-11 Thread Jakub Jelinek
On Tue, Jun 11, 2019 at 11:50:40AM +0200, Jakub Jelinek wrote: > The rest is just a general comment on the preexisting code. > Using a bunch of const char *whatever = _("..."); > at the start of function is undesirable, it means any time this function is > called, even in the likely case there is n