Re: [PATCH] check_cfg assert fix

2011-09-19 Thread Maxim Kuvyrkov
On 14/09/2011, at 7:40 AM, Maxim Kuvyrkov wrote: > > OK then, attached is the trivial patch that removes > haifa-sched.c:check_cfg(). Please let me know if you have strong feelings > towards keeping check_cfg(). > > Tested on x86_64-linux-gnu. Absent any requests to the contrary, I will > ch

Re: [PATCH] check_cfg assert fix

2011-09-13 Thread Maxim Kuvyrkov
On 9/09/2011, at 6:54 AM, Bernd Schmidt wrote: > On 09/06/11 23:56, Maxim Kuvyrkov wrote: >> I agree. I would rather remove the entirety of haifa-sched.c: >> check_cfg(); scheduler is not the right place for checking >> consistency of CFG. Check_cfg() was useful for debugging scheduler >> patche

Re: [PATCH] check_cfg assert fix

2011-09-08 Thread Bernd Schmidt
On 09/06/11 23:56, Maxim Kuvyrkov wrote: > I agree. I would rather remove the entirety of haifa-sched.c: > check_cfg(); scheduler is not the right place for checking > consistency of CFG. Check_cfg() was useful for debugging scheduler > patches, but now it is more of maintainance overhead. > > D

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Maxim Kuvyrkov
On 7/09/2011, at 9:32 AM, Steven Bosscher wrote: > On Tue, Sep 6, 2011 at 11:31 PM, Steven Bosscher > wrote: >> Index: haifa-sched.c >> === >> --- haifa-sched.c (revision 178601) >> +++ haifa-sched.c (working copy) >> @@

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Steven Bosscher
On Tue, Sep 6, 2011 at 11:31 PM, Steven Bosscher wrote: > Index: haifa-sched.c > === > --- haifa-sched.c       (revision 178601) > +++ haifa-sched.c       (working copy) > @@ -6071,7 +6071,10 @@ check_cfg (rtx head, rtx tail) >      

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Steven Bosscher
On Tue, Sep 6, 2011 at 8:00 PM, Maxim Kuvyrkov wrote: > > On 7/09/2011, at 3:13 AM, Steven Bosscher wrote: > >> On Tue, Sep 6, 2011 at 11:14 AM, Tom de Vries wrote: >>> Hi, >>> >>> During testing the approved-for-commit middle-end patch for bug 43864 on >>> ARM, I >>> ran into a gcc.dg/torture/p

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Maxim Kuvyrkov
On 7/09/2011, at 3:13 AM, Steven Bosscher wrote: > On Tue, Sep 6, 2011 at 11:14 AM, Tom de Vries wrote: >> Hi, >> >> During testing the approved-for-commit middle-end patch for bug 43864 on >> ARM, I >> ran into a gcc.dg/torture/pr46068.c ICE. >> >> The following assert in haifa-sched.c:check

Re: [PATCH] check_cfg assert fix

2011-09-06 Thread Steven Bosscher
On Tue, Sep 6, 2011 at 11:14 AM, Tom de Vries wrote: > Hi, > > During testing the approved-for-commit middle-end patch for bug 43864 on ARM, > I > ran into a gcc.dg/torture/pr46068.c ICE. > > The following assert in haifa-sched.c:check_cfg triggered: > ... >                  else if (any_condjump

[PATCH] check_cfg assert fix

2011-09-06 Thread Tom de Vries
Hi, During testing the approved-for-commit middle-end patch for bug 43864 on ARM, I ran into a gcc.dg/torture/pr46068.c ICE. The following assert in haifa-sched.c:check_cfg triggered: ... else if (any_condjump_p (head)) gcc_assert (/* Usual case. */